Open
Conversation
14 tasks
skarard
added a commit
to skarard/ch57x-keyboard-tool
that referenced
this pull request
Mar 10, 2026
The 8850 uses a different mouse packet format than K884x. Confirmed via Frida capture of mini_keyboard.exe and PR kriomant#154 by yawor: - Position [5] starts mouse_data (not 0x00 padding like keyboard type) - Format: [1, 4, 0, 0, modifier, 0, 0, buttons, 0, 0, dx, 0, 0, dy, 0, 0, wheel] - Mouse modifier uses same firmware IDs (F1=Ctrl, F2=Shift, F3=Alt) - Button bitmap: 1=left, 2=right, 4=middle Hardware tested: clicks, scroll wheel, and mouse move all confirmed working. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
skarard
added a commit
to skarard/ch57x-keyboard-tool
that referenced
this pull request
Mar 10, 2026
The 8850 uses a different mouse packet format than K884x. Confirmed via Frida capture of mini_keyboard.exe and PR kriomant#154 by yawor: - Position [5] starts mouse_data (not 0x00 padding like keyboard type) - Format: [1, 4, 0, 0, modifier, 0, 0, buttons, 0, 0, dx, 0, 0, dy, 0, 0, wheel] - Mouse modifier uses same firmware IDs (F1=Ctrl, F2=Shift, F3=Alt) - Button bitmap: 1=left, 2=right, 4=middle Hardware tested: clicks, scroll wheel, and mouse move all confirmed working. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
skarard
added a commit
to skarard/ch57x-keyboard-tool
that referenced
this pull request
Mar 10, 2026
Map 0x8850 directly to Keyboard8850 (matching yawor's PR kriomant#154 approach). Remove VENDOR_ID_ALT — users with VID 0x514C can use --vendor-id flag. Revert find_device to upstream logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
skarard
added a commit
to skarard/ch57x-keyboard-tool
that referenced
this pull request
Mar 10, 2026
Send the finalize packet [03 FD FE FF] after each bind_key call (matching yawor's PR kriomant#154 approach) instead of adding a new trait method. This keeps the Keyboard trait unchanged from upstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
This PR adds support for a 4x4, 3 knob keyboard, which reports as 514c:8850 - mentioned in #153. As far as I've seen the VID/PID pair may not be unique enough to discern this keyboard from a different one (4x3, 4 knobs, mentioned in #136), so there may be a conflict with one or more types of keyboards with different implementations, so some mechanism is needed to select the correct implementation. For now I've assigned this new implementation to PID 8850 in this PR for development.
Currently all keyboard, multimedia and mouse bindings are implemented and seem to work properly. No LED support yet.