Open
Conversation
The K8850 (VID 0x514C, PID 0x8850) uses a different key binding protocol (0xFD command) than the K884x family (0xFE command). Protocol details reverse-engineered via Frida HID captures of mini_keyboard.exe and verified on hardware for all binding types: keyboard, modifiers, macros, media, mouse, and knobs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e9a1cc4 to
a2700fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ledssection per layer) and CLI (ledcommand)#RRGGBBk8850.rs— shared files only pass through opaqueserde_yaml::ValueBuilt on top of #174 (K8850 key binding support) — that PR should be merged first.
LED protocol
YAML config example
Known caveats
ledcommand overwrites all layers: EachledCLI call sends packets for all 3 layers, setting the target layer and zeroing the others. Use YAML config for multi-layer LED setups.ledsconfig is optional: Layers without aledssection are left unchanged. Configs without anyledssections skip LED protocol entirely.Design
LED-specific types (
LedMode,Color, parsers) are fully contained ink8850.rs. Shared files (config.rs,mod.rs,main.rs) only pass through an opaqueserde_yaml::Valuefor theledsfield, keeping the cross-cutting diff minimal and allowing other keyboard drivers to define their own LED formats in the future.Hardware tested
All testing performed on XZKJ-16key_3knob (VID 0x514C / PID 0x8850) by @skarard:
#RRGGBB)🤖 Generated with Claude Code — reviewed and hardware tested by @skarard