fieldModifier should apply to encoder names as well#48
Open
supermario wants to merge 1 commit intokrisajenkins:masterfrom
Open
fieldModifier should apply to encoder names as well#48supermario wants to merge 1 commit intokrisajenkins:masterfrom
supermario wants to merge 1 commit intokrisajenkins:masterfrom
Conversation
Author
|
In looking at fixing the failed tests – it seems my "fix" creates a dilemma.
The two conflicting implementation choices for
I.e. in my case, I don't want prefixes like It seems it's not possible to have both these behaviours accommodated with a single Interested in your thoughts @krisajenkins – perhaps I need to keep my own fork for my scenario. Or did I miss something? |
supermario
added a commit
to supermario/elm-export
that referenced
this pull request
Dec 23, 2017
This reverts commit cb1966c.
bchase
added a commit
to bchase/elm-export
that referenced
this pull request
Jan 25, 2018
`Options` * change `fieldLabelModifier` to `elmRecordFieldModifier` * provide `jsonKeyModifier` * apply these modifiers to generated Elm types, decoders, and encoders (see also: discussion in krisajenkins#48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I have:
And I'm using the
fieldLabelModifier:The
fieldLabelModifiershould apply to theencoderfield as well, otherwise, my types are mismatched: