Potential fix for code scanning alert no. 3: Clear-text logging of sensitive information #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Howdy and thanks for contributing to our repo. We review new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/krishnprakash/cloudflare-docs/security/code-scanning/3
To fix the problem, we need to ensure that sensitive information such as
client_secretis not logged in clear text. Instead of logging the actualclient_secret, we can log a message indicating that a service token was created without revealing the sensitive details. This way, we maintain the functionality of informing the user about the creation of the service token without exposing sensitive information.We will modify the code in the file
public/cloudflare-one/static/authenticated-doh.pyto remove the logging ofclient_secretand replace it with a more generic message.Suggested fixes powered by Copilot Autofix. Review carefully before merging.