Conversation
This change makes the internal transcription notation, which uses the names of the tengwa, less shy about using the proper names, particularly with the use of diacritics where appropriate, and using the proper names for vowel carriers.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kriskowal/tengwarjs/q03nwci11 |
|
I was sadly unable to give vowels the same treatment, since these do not consistently have names, some of the names appear only in combination with specific tengwar, and names like sa-rince do not fully describe the flourish variations that are expressible with the fonts. |
arnog
left a comment
There was a problem hiding this comment.
looks good (but see 1 typo: that's the requested change).
As a side note, it's always a bit risky to use non-ASCII chars in strings intended to be used for programming. For example, AFAIK the Regex engines of most Javascript engines do not handle as one would expect accented characters. There are Unicode variants of those that are available, but they are inconsistent, and AFAIR Firefox doesn't support it.
As an alternative, you could use "nuumen" for "númen", etc...
| breaks. | ||
| - `plain` whether to exclude all HTML from the output, | ||
| making it suitable for plain text.. | ||
| - `viyla`: In the earlier forms of the mode, the tengwa |
This change makes the internal transcription notation, which uses the names of the tengwa, less shy about using the proper names, particularly with the use of diacritics where appropriate, and using the proper names for vowel carriers.
It’s my hope that this makes the tests more palatable as a shared asset among transcribers.