always try to return a real makeNewEmptyModel#682
Draft
rudiedirkx wants to merge 5 commits intokristijanhusak:masterfrom
Draft
always try to return a real makeNewEmptyModel#682rudiedirkx wants to merge 5 commits intokristijanhusak:masterfrom
rudiedirkx wants to merge 5 commits intokristijanhusak:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably too invasive, and maybe still broken, but it's a way to always get an empty model, even if you don't set
empty_model. Because currently the parent's model is used for the child's model and that's just weird (wrong class) and wrong (if fields/columns/properties match, the parent's values are used).