Implemented fifo opening with retries.#9
Open
RomanShumkov wants to merge 1 commit intokriswallsmith:masterfrom
Open
Implemented fifo opening with retries.#9RomanShumkov wants to merge 1 commit intokriswallsmith:masterfrom
RomanShumkov wants to merge 1 commit intokriswallsmith:masterfrom
Conversation
fopen may fail temporarily (e.g. "failed to open stream: Interrupted system call" when there are 30+ forks). It's critical to handle fifo opening errors because of blocking read in child. Child is waiting forever if no parent connects.
Owner
|
Thanks for your work, @RomanShumkov. I'm curious why you have a different value passed to |
Open
Contributor
Author
|
These Don't have much time for implementing tests at the moment. Maybe in nearest future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fopen may fail temporarily (e.g. "failed to open stream: Interrupted system call" when there are 30+ forks).
It's critical to handle fifo opening errors because of blocking read in child. Child is waiting forever if no parent connects.