Skip to content

Updating to use krkn-lib virt functions#989

Merged
paigerube14 merged 5 commits intokrkn-chaos:mainfrom
paigerube14:kubevirt_krkn_lib
Feb 27, 2026
Merged

Updating to use krkn-lib virt functions#989
paigerube14 merged 5 commits intokrkn-chaos:mainfrom
paigerube14:kubevirt_krkn_lib

Conversation

@paigerube14
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization

Description

Updating to use virt functions from krkn lib for reusability

Related Tickets & Documents

  • Related Issue #
  • Closes #

Documentation

  • Is documentation needed for this update?

If checked, a documentation PR must be created and merged in the website repository.

Related Documentation PR (if applicable)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Copy link
Collaborator

@tsebastiani tsebastiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@paigerube14 paigerube14 force-pushed the kubevirt_krkn_lib branch 3 times, most recently from 4f3358a to f401fc6 Compare December 17, 2025 20:10
@chaitanyaenr
Copy link
Collaborator

@yogananth-subramanian need your help testing this change when you get a chance please. Thanks!

@chaitanyaenr
Copy link
Collaborator

@paigerube14 functional tests seem to be failing because of

ERROR: test_patch_vm_spec_api_exception (test_kubevirt_vm_outage.TestKubevirtVmOutageScenarioPlugin)
Test patch_vm_spec handles ApiException
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/krkn/krkn/tests/test_kubevirt_vm_outage.py", line 89, in setUp
    "creationTimestamp": (base_time + timedelta(minutes=1)).isoformat() + "Z"
NameError: name 'base_time' is not defined

@paigerube14
Copy link
Collaborator Author

@paigerube14 functional tests seem to be failing because of

ERROR: test_patch_vm_spec_api_exception (test_kubevirt_vm_outage.TestKubevirtVmOutageScenarioPlugin)
Test patch_vm_spec handles ApiException
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/krkn/krkn/tests/test_kubevirt_vm_outage.py", line 89, in setUp
    "creationTimestamp": (base_time + timedelta(minutes=1)).isoformat() + "Z"
NameError: name 'base_time' is not defined

Will take a look, thanks!

Assisted By: Claude Code

Signed-off-by: Paige Patton <prubenda@redhat.com>
@paigerube14 paigerube14 merged commit c474b81 into krkn-chaos:main Feb 27, 2026
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants