fix: remove panic in IsFile() on file close error

[AR21SM]

User description

Description

Fixes #93

The IsFile() function in pkg/typing/types.go uses panic() to handle file close errors. This can crash the application when running on network filesystems or container volumes where I/O errors may occur during file.Close().

For read-only file handles, close errors can be safely ignored. This PR removes the panic and silently discards the close error.

Before:

defer func() {
    if err == nil && file != nil {
        deferErr := file.Close()
        if deferErr != nil {
            panic(deferErr)
        }
    }
}()

After :

defer func() {
    if file != nil {
        _ = file.Close()
    }
}()

---

PR Type

Bug fix

---

Description

• Remove panic on file close error in IsFile() function

• Safely ignore close errors for read-only file handles

• Prevent application crashes on network filesystems

---

Diagram Walkthrough

flowchart LR
  A["IsFile() function"] --> B["Open file"]
  B --> C["Defer cleanup"]
  C --> D["Old: panic on close error"]
  C --> E["New: silently ignore close error"]
  D --> F["Application crash risk"]
  E --> G["Graceful error handling"]

Loading

File Walkthrough

	Relevant files
Bug fix	types.go Remove panic on file close error handling                                pkg/typing/types.go Removed panic statement from file close error handling in IsFile() Simplified defer cleanup logic to safely ignore close errors Changed from conditional error checking to unconditional file close Prevents application crashes on network filesystems or container volumes +2/-5

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡	🎫 #93 🟢 Update IsFile() in pkg/typing/types.go to avoid using panic() when file.Close() returns an error, preventing application crashes on close failures. For read-only file handles in IsFile(), safely ignore Close() errors (e.g., _ = file.Close()). 🔴 Review and address similar panic()-on-close patterns mentioned in pkg/utils/utils_function.go and pkg/scenarioorchestrator/utils/utils.go.
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Ignored close error: The new code explicitly ignores file.Close() errors, which may silently swallow I/O failures unless this is intentionally acceptable for the function's contract. Referred Code if file != nil { _ = file.Close() } Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Verify regular file type Improve the file check by handling any error from os.Stat and verifying the path is a regular file using info.Mode().IsRegular(). pkg/typing/types.go [84-86] -if _, err := os.Stat(f); errors.Is(err, os.ErrNotExist) { +info, err := os.Stat(f) +if err != nil { + return false +} +if !info.Mode().IsRegular() { return false } [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: This suggestion correctly identifies a logic bug where the function could return true for directories and only checks for os.ErrNotExist. The proposed change improves correctness by handling all os.Stat errors and ensuring the path is a regular file.	Medium
General	Simplify file close defer Replace the deferred anonymous function with a more idiomatic if err == nil { defer file.Close() } immediately after os.Open. pkg/typing/types.go [90-94] -defer func() { - if file != nil { - _ = file.Close() - } -}() +if err == nil { + defer file.Close() +} Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion proposes a more idiomatic Go pattern for deferring file.Close(), which improves code readability and simplicity by removing the explicit closure.	Low
Update

[AR21SM]

@tsebastiani @paigerube14 gentle ping for review when you get a chance! 🙂

[tsebastiani]

please update the fork and rebase on main

[AR21SM]

please update the fork and rebase on main

done

[AR21SM]

@tsebastiani