Open
Conversation
Owner
|
Test are broken its always using one version of mysql I didn't have time to check this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added MySQL 9.0 to the CI and after the pipeline failed with just a single test i found out that the version constraint in
src/MySQLReplication/Repository/MySQLRepository.phpwas checked using a string constraint while insrc/MySQLReplication/BinLog/BinLogSocketConnect.phpthere wasversion_compareutilized for versions higher then MySQL 7. So i took over this comparison and everything seems compatible with the newer MySQL version.Wanted to try with MySQL 9.6 but MySQL 9.0 is the latest version supported by the CI action
shogo82148/actions-setup-mysql. But surely this is also a step forward for people utilizing the latest versions 😄