-
Notifications
You must be signed in to change notification settings - Fork 62
Layer config updates #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mvp_demo
Are you sure you want to change the base?
Layer config updates #1790
Conversation
Signed-off-by: kusuma chalasani <kchalasa@redhat.com>
Signed-off-by: kusuma chalasani <kchalasa@redhat.com>
Reviewer's GuideUpdates autotune layer configurations by fixing memory request bounds format in the container config and introducing a new Semeru JVM layer (renaming from OpenJ9) with Prometheus-based presence detection and GC-related tunables. Class diagram for updated KruizeLayer configurationsclassDiagram
class KruizeLayer {
string apiVersion
string kind
string metadata_name
string layer_name
int layer_level
string details
}
class LayerPresenceQuery {
string datasource
string query
string key
}
class Tunable {
string name
string description
string value_type
string lower_bound
string upper_bound
int step
string[] choices
}
class ContainerLayer {
string layer_name
string tunable_memoryRequest_upper_bound
string tunable_memoryRequest_lower_bound
int tunable_memoryRequest_step
}
class SemeruLayer {
string layer_name
string[] heap_memory_queries
string tunable_GCPolicy_value_type
string[] tunable_GCPolicy_choices
string tunable_MaxRAMPercentage_value_type
string tunable_MaxRAMPercentage_lower_bound
string tunable_MaxRAMPercentage_upper_bound
int tunable_MaxRAMPercentage_step
}
KruizeLayer "1" *-- "many" LayerPresenceQuery
KruizeLayer "1" *-- "many" Tunable
ContainerLayer --|> KruizeLayer
SemeruLayer --|> KruizeLayer
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Now that
memoryRequestbounds are unitless values, double‑check that all consumers of this layer treat them as MiB and consider standardizing how units are represented for tunables to avoid ambiguity. - The
semerulayerlayer_presencesection has several overlapping Prometheus queries for heap (e.g.,tenured-.+andtenured); consider consolidating these with a single, clearer regex to reduce redundancy and simplify maintenance.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that `memoryRequest` bounds are unitless values, double‑check that all consumers of this layer treat them as MiB and consider standardizing how units are represented for tunables to avoid ambiguity.
- The `semeru` layer `layer_presence` section has several overlapping Prometheus queries for heap (e.g., `tenured-.+` and `tenured`); consider consolidating these with a single, clearer regex to reduce redundancy and simplify maintenance.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
Update the layer configs. This PR fixes
Fixes # (issue)
Type of change
Summary by Sourcery
Update container layer configuration and add a new Semeru JVM layer definition.
New Features:
Bug Fixes: