generated from ks6088ts/template-python
-
Notifications
You must be signed in to change notification settings - Fork 0
add post_summary_to_slack workflow #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,62 @@ | ||||||
| name: post_summary_to_slack | ||||||
|
|
||||||
| on: | ||||||
| workflow_dispatch: | ||||||
| inputs: | ||||||
| text: | ||||||
| type: string | ||||||
| default: "https://example.com,https://www.youtube.com/watch?v=xxx" | ||||||
| required: true | ||||||
| description: "Comma-separated list of URLs to summarize" | ||||||
| scraper_type: | ||||||
| type: choice | ||||||
| options: | ||||||
| - mock | ||||||
| - httpx | ||||||
| - youtube_transcript | ||||||
| default: mock | ||||||
| required: true | ||||||
| description: "Scraper implementation" | ||||||
| summarizer_type: | ||||||
| type: choice | ||||||
| options: | ||||||
| - mock | ||||||
| - llm | ||||||
| default: mock | ||||||
| required: true | ||||||
| description: "Summarizer implementation" | ||||||
| notifier_type: | ||||||
| type: choice | ||||||
| options: | ||||||
| - mock | ||||||
| - slack | ||||||
| default: mock | ||||||
| required: true | ||||||
| description: "Notifier implementation" | ||||||
|
|
||||||
| env: | ||||||
| SCRAPER_TYPE: ${{ inputs.scraper_type }} | ||||||
| SUMMARIZER_TYPE: ${{ inputs.summarizer_type }} | ||||||
| NOTIFIER_TYPE: ${{ inputs.notifier_type }} | ||||||
| AZURE_OPENAI_ENDPOINT: ${{ secrets.AZURE_OPENAI_ENDPOINT }} | ||||||
| AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }} | ||||||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} | ||||||
|
|
||||||
| jobs: | ||||||
| post_summary_to_slack: | ||||||
| runs-on: "ubuntu-latest" | ||||||
| timeout-minutes: 5 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A 5-minute timeout may be insufficient for scraping multiple URLs and generating summaries, especially when using LLM-based summarization. Consider increasing the timeout to 10-15 minutes to prevent premature job cancellation.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| steps: | ||||||
| - uses: actions/checkout@v4 | ||||||
| - name: Set up uv | ||||||
| shell: bash | ||||||
| run: pipx install uv | ||||||
| - name: Set up Python 3.13 | ||||||
| uses: actions/setup-python@v5 | ||||||
| with: | ||||||
| python-version: 3.13 | ||||||
| - name: Running NewsSummarizerAgent with scraper ${{ env.SCRAPER_TYPE }}, summarizer ${{ env.SUMMARIZER_TYPE }}, notifier ${{ env.NOTIFIER_TYPE }} | ||||||
| shell: bash | ||||||
| run: | | ||||||
| make install-deps | ||||||
| uv run python scripts/agent_operator.py news-summarizer-agent --urls "${{ inputs.text }}" | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default URLs include a placeholder YouTube URL with 'xxx' which could be confusing to users. Consider using a real example URL or a more descriptive placeholder like 'YOUTUBE_VIDEO_ID'.
Copilot uses AI. Check for mistakes.