Skip to content

Conversation

ks6088ts
Copy link
Member

What this PR does / why we need it

  • ...

Which issue(s) this PR fixes:

Fixes #

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [email protected]:ks6088ts-labs/workshop-azure-openai.git
cd workshop-azure-openai
  • Test the code
make ci-test

What to Check

Verify that the following are valid

  • ...

Additional Information

@ks6088ts ks6088ts requested a review from Copilot May 19, 2025 22:56
@ks6088ts ks6088ts self-assigned this May 19, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the repository from using Poetry to using UV as the dependency and task runner, updating configuration, CI, documentation, and tooling calls accordingly.

  • Replace [tool.poetry] with PEP 621 [project] table and add [tool.uv] config
  • Update Makefile, Dockerfile, GitHub Actions, devcontainer, and docs to use uv commands instead of poetry
  • Switch build backend from Poetry Core to Hatchling and add a wheel target

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Migrate metadata and dependencies from Poetry to UV; configure Hatchling wheel target
poetry.toml Remove Poetry virtualenv config
docs/index.md Update installation link from Poetry to UV
docs/apps/... Replace poetry run calls with uv run
apps/12_langgraph_agent/... Remove extra blank line in GradeAnswer
apps/11_promptflow/... Remove extra blank line in accuracy_aggregate
Makefile Swap Poetry commands for UV equivalents
Dockerfile Use UV to install and export dependencies
.github/workflows/test.yaml Set up UV instead of Poetry in CI workflow
.devcontainer/devcontainer.json Install UV in devcontainer and forward ports
Comments suppressed due to low confidence (3)

pyproject.toml:5

  • After migrating to the PEP 621 [project] table, the authors and license fields were removed. Consider re-adding them under [project] so your package metadata remains complete and PEP-compliant.
readme = "README.md"

.github/workflows/test.yaml:32

  • [nitpick] The CI workflow no longer caches dependencies, which may slow down runs. Consider adding a cache step (e.g., using actions/cache) for Python or pipx installs to improve build times.
#          cache: "poetry"

Dockerfile:7

  • This line references uv.lock but the lock file may not exist or be up to date. Ensure uv.lock is generated and committed so that the build stage can successfully copy and use it.
COPY ./pyproject.toml ./uv.lock /tmp/

Here are the preferred tools for development.

- [Poetry](https://python-poetry.org/docs/#installation)
- [uv](https://docs.astral.sh/uv/getting-started/installation/)
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For consistency and clarity across the docs, consider capitalizing the tool name in the link label (e.g., UV instead of uv).

Suggested change
- [uv](https://docs.astral.sh/uv/getting-started/installation/)
- [UV](https://docs.astral.sh/uv/getting-started/installation/)

Copilot uses AI. Check for mistakes.

@ks6088ts ks6088ts force-pushed the feature/issue-237_foundry-local branch from 94bb171 to 59d4883 Compare May 19, 2025 23:02
@ks6088ts ks6088ts merged commit bc226ee into main May 19, 2025
6 checks passed
@ks6088ts ks6088ts deleted the feature/issue-237_foundry-local branch May 19, 2025 23:05
@ks6088ts ks6088ts restored the feature/issue-237_foundry-local branch May 19, 2025 23:05
@ks6088ts ks6088ts deleted the feature/issue-237_foundry-local branch May 19, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant