Skip to content

Conversation

ks6088ts
Copy link
Member

@ks6088ts ks6088ts commented May 1, 2025

What this PR does / why we need it

  • set up playwright

Which issue(s) this PR fixes:

Fixes #1

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
ORGANIZATION=<organization-name>
REPOSITORY=<repository-name>

git clone [email protected]:$ORGANIZATION/$REPOSITORY.git
cd $REPOSITORY
  • Test the code
make ci-test

What to Check

Verify that the following are valid

  • ...

Additional Information

@ks6088ts ks6088ts requested a review from Copilot May 1, 2025 04:05
@ks6088ts ks6088ts self-assigned this May 1, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up Playwright for the repository by introducing new tests, updating project dependencies, and enhancing the documentation with setup and usage instructions.

  • Added Playwright-based tests to scrape bookmarks and verify pages in tests/test_hatena_bookmark.py and tests/test_core.py.
  • Updated pyproject.toml with Playwright and pytest-playwright dependencies.
  • Enhanced docs/index.md with installation and guide details.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

File Description
tests/test_hatena_bookmark.py New test to extract bookmark info from Hatena bookmark page.
tests/test_core.py Added tests to verify page titles and navigation via Playwright.
pyproject.toml Updated dependencies to include Playwright packages.
docs/index.md Included installation instructions and guides for Playwright.
Files not reviewed (1)
  • Makefile: Language not supported

@ks6088ts ks6088ts merged commit 11db918 into main May 1, 2025
4 checks passed
@ks6088ts ks6088ts deleted the feature/issue-1_setup-playwright branch May 1, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set up playwright
1 participant