Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR expands the IMU data structure to include a timestamp and effective frequency field, while adding logic to parse new timestamp frames from the Hiwonder device and updating dependency versions.
- Expanded ImuData in imu-traits to support timestamps and effective frequency.
- Updated Hiwonder reader to parse and assign timestamp information from device-provided time fields.
- Bumped dependency versions across multiple Cargo.toml files.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| imu/imu-traits/src/lib.rs | Expanded ImuData with timestamp and effective_frequency fields. |
| imu/drivers/hiwonder/src/lib.rs | Added parsing logic for timestamp frames and effective frequency update. |
| imu/drivers/*/Cargo.toml | Updated version numbers and dependencies accordingly. |
| imu/bindings/src/lib.rs | Added Python binding for Timestamp. |
| imu/init.py | Updated module exports with Timestamp. |
| Cargo.toml | Bumped workspace version. |
Comments suppressed due to low confidence (1)
imu/drivers/hiwonder/src/lib.rs:398
- The addition of 1 to the year value may be incorrect because years are not 1-indexed. Verify whether this offset is intentional or if it unintentionally shifts the timestamp year.
year as i32 + 1,
Contributor
|
Found and discussed error with warmup time. Please refer to Scott's implementation: https://github.com/kscalelabs/kos-zbot/blob/master/kos_zbot/imu.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hiwonder has a timestamp field we want to access. Also, we want to know the effective frequency of the imu reader (i.e. how often we are receiving new data)
Solution
ImuDatato include timestamp and effective frequencyValidation
^^ running
cargo run --bin read_hiwonderChecklist