Open
Conversation
|
Thank you for this PR. I went ahead and forked the repo and pulled in your PR to resolve an issue I had with using this with Jest. I hope this is merged into this repo too tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I am using this dependency to help me build an isomorphic NPM module which has both ESM and CommonJS distributions. I wasn't able to do this without the addition of a CommonJS export to this package, which is currently ESM only.
index.node.cjsindex.node.jstoindex.node.mjsimportandrequireconditions to thenodeexport inpackage.jsonmainto point at the.cjs, and added amodulekey which points at the.mjsvariant