Add support for Discussion Topics/Announcements #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avadoc comments for DiscussionTopicWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is my first real attempt at contributing to a project like this, so any feedback is welcome.
I'm currently working on a bit of software for my senior project at CSULB and found this library very useful for our purposes. However, it didn't appear to have any implementation of Discussion Topics/Announcements (Canvas considers these the same thing on the back end), which my team needs for our project. So, I gave it a shot and tried implementing that support based on what was already here.
I have been able to test and confirm that my implementation does work for retrieving basic Announcement information from Canvas, which for the purposes of my team's project is sufficient, but it would of course be ideal if the full functionality is correct for anyone else who may find it helpful.
Unfortunately, I'm only working with my student Canvas account, so I don't have write permissions for these objects. I can't say I've tested my implementation for posting, deleting, or editing Discussion Topics or Announcements, only that I followed the patterns already present in the library for doing so, and made my best attempt to match the functionality to the Canvas LMS REST API Documentation.
My team is using Maven to manage our project dependencies, so an update to the central Maven repository would be greatly appreciated if this contribution is approved.