Switch to onelogin/php-saml and bump to 1.0.0#21
Open
ktbartholomew wants to merge 1 commit intomasterfrom
Open
Switch to onelogin/php-saml and bump to 1.0.0#21ktbartholomew wants to merge 1 commit intomasterfrom
ktbartholomew wants to merge 1 commit intomasterfrom
Conversation
…ewrite everything
This was referenced Apr 28, 2017
|
Hi! What is the status of the PR? Are you still testing? Will this make your plugin PHP 7 compatible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a rewrite. #20 essentially precludes the use of SimpleSAMLPHP, which is extremely difficult to consume as a portable library and not a standalone web app. By using OneLogin's library, we can more elegantly configure the SAML service provider, and most likely handle multisite scenarios MUCH better.
A major revision change is also a good time to abandon some poor decisions from years ago, like storing certificates on the filesystem and depending on very specific URL handling to identify the current site in a multisite setup.
The focus for this PR is to modernize the plugin, make it more predictable going forward, but not to preserve lots of backwards compatibility for versions <1.0.0