Create pull_request_template.md#291
Open
tyilo wants to merge 1 commit intokth-competitive-programming:mainfrom
Open
Create pull_request_template.md#291tyilo wants to merge 1 commit intokth-competitive-programming:mainfrom
tyilo wants to merge 1 commit intokth-competitive-programming:mainfrom
Conversation
Contributor
Author
|
Ping @simonlindholm |
Member
|
Right. Yeah, it's a reasonable idea. I'm not in love with the suggested wording though, the second sentence makes it sound like the problem is with unwanted changes rather than accidental ones, and the template will apply even to PRs to forks where the first sentence doesn't make sense. |
Contributor
Author
|
Fair enough. Any suggestions? |
Member
|
Not off the top of my head, this kind of wordsmithing always takes me forever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PR template to try to prevent people from creating PR's by mistake.