Skip to content

Conversation

@Matistjati
Copy link
Contributor

@Matistjati Matistjati commented Jan 3, 2026

In geometry, it's mixed whether points are passed as P&, const P& or P. We should probably be consistent. Personally, I prefer just P. We should never have P&: then you can't do reasonable things such as:

auto eval = [&](double p) {
    return segDist(a, b, c + delta * p);
};

@Matistjati
Copy link
Contributor Author

We probably shouldn't merge this yet. I haven't tested these changes, and there might be more changes to make. But I want to get the discussion going @simonlindholm

@simonlindholm
Copy link
Member

Sounds like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants