Add documentation for 3.4.0 #741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add multiple header parsing to "what's new" * add multiple header parsing to client-responses.md
fix: KTOR-8880
* KTOR-9150 Add documentation for partial HTML response * fix formatting, grammar, and language in server-responses.md
* fix: add Whats New section * Apply suggestions from code review Co-authored-by: Vik Nikolova <[email protected]> * KTOR-9185 Add a new topic and project sample for the HttpRequestLifecycle plugin --------- Co-authored-by: Vik Nikolova <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* KTOR-9175 Add api key auth documentation --------- Co-authored-by: Vik Nikolova <[email protected]>
AlejandraPedroza
requested changes
Dec 19, 2025
AlejandraPedroza
left a comment
AlejandraPedroza
left a comment
There was a problem hiding this comment.
Huge work! I left some suggestions. Please check:
- External links (especially those pointing to ktorio repo on GitHub), as they appear as page not found.
- Code comments that should be in 3rd person verb, above the code line, and other criteria listed in our style guide.
- Consistency across plugin names, which in some cases appear in monospaced fonts and in some cases they not.
- Functions that may be missing
()next to their names.
codeSnippets/snippets/server-http-request-lifecycle/src/main/kotlin/com/example/Application.kt
Outdated
Show resolved
Hide resolved
codeSnippets/snippets/server-http-request-lifecycle/src/main/kotlin/com/example/Application.kt
Outdated
Show resolved
Hide resolved
codeSnippets/snippets/server-http-request-lifecycle/src/test/kotlin/ApplicationTest.kt
Outdated
Show resolved
Hide resolved
AlejandraPedroza
requested changes
Dec 19, 2025
AlejandraPedroza
left a comment
AlejandraPedroza
left a comment
There was a problem hiding this comment.
Huge work! I left some suggestions. Please check:
- External links (especially those pointing to ktorio repo on GitHub), as they appear as page not found.
- Code comments that should be in 3rd person verb, above the code line, and other criteria listed in our style guide.
- Consistency across plugin names, which in some cases appear in monospaced fonts and in some cases they not.
- Functions that may be missing
()next to their names.
…#742) * add a what's new entry for dispatcher config for native client engines * fix broken API link and add a new one for engine configs
AlejandraPedroza
approved these changes
Dec 29, 2025
AlejandraPedroza
left a comment
AlejandraPedroza
left a comment
There was a problem hiding this comment.
Thanks for the changes. LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New topics:
whats-new-340.md)server-http-request-lifecycle.md)server-api-key-auth.md)New sections:
client-auth.md)client-responses.md)server-compression.md)server-html-dsl.md)client-plugins,client-default-request)server-responses.md)Improved formatting, grammar and language:
server-responses.md)server-basic-auth.md,server-bearer-auth)New code samples:
server-http-lifecycle