KTOR-9211 Fix SendCountExceedException when max retries is lesser tha… #5331
+60
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughHttpSend max-send calculation now derives maxSendCount from a per-request MaxRetries attribute when larger than the plugin default (with Int.MAX_VALUE guard); DefaultSender uses maxSendCount. Two tests added to verify interactions between maxRetries and maxSendCount. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/HttpRequestRetryTest.kt`:
- Around line 551-573: Rename the test function
testMaxSendCountGreaterThanMaxRetries to follow the DescribeWhatIsBeingTested
pattern (for example maxSendCountGreaterThanMaxRetriesAllowsRedirect) while
keeping the `@Test` annotation and the same body; update any references if the
test name is used elsewhere (e.g., test discovery or logging) so the test still
runs and clearly describes the behavior being verified in
HttpRequestRetryTest.kt.
Comment on lines
+551
to
+573
| @Test | ||
| fun testMaxSendCountGreaterThanMaxRetries() = testWithEngine(MockEngine) { | ||
| config { | ||
| engine { | ||
| addHandler { request -> | ||
| if (request.url.toString().endsWith("/ok")) { | ||
| respondOk() | ||
| } else { | ||
| respondRedirect("/ok") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| install(HttpRequestRetry) { | ||
| retryOnServerErrors(maxRetries = 0) | ||
| delayMillis { 0L } | ||
| } | ||
| } | ||
|
|
||
| test { client -> | ||
| assertEquals(HttpStatusCode.OK, client.get("/").status) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Rename test to follow required naming pattern.
Please use the DescribeWhatIsBeingTested format (per test guidelines). As per coding guidelines, consider renaming to something like maxSendCountGreaterThanMaxRetriesAllowsRedirect.
🔧 Suggested rename
- fun testMaxSendCountGreaterThanMaxRetries() = testWithEngine(MockEngine) {
+ fun maxSendCountGreaterThanMaxRetriesAllowsRedirect() = testWithEngine(MockEngine) {🤖 Prompt for AI Agents
In
`@ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/HttpRequestRetryTest.kt`
around lines 551 - 573, Rename the test function
testMaxSendCountGreaterThanMaxRetries to follow the DescribeWhatIsBeingTested
pattern (for example maxSendCountGreaterThanMaxRetriesAllowsRedirect) while
keeping the `@Test` annotation and the same body; update any references if the
test name is used elsewhere (e.g., test discovery or logging) so the test still
runs and clearly describes the behavior being verified in
HttpRequestRetryTest.kt.
Nek-12
reviewed
Jan 26, 2026
ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/HttpSend.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTOR-9211