Skip to content

Fix get and set implementations for Uint8Array and ArrayLike #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bashor wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

Fix get and set implementations for Uint8Array and ArrayLike #5340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ktor-client/ktor-client-core/wasmJs/src/io/ktor/client/fetch/LibEs5.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,16 @@ public external interface Uint8Array : JsAny {
}

@Suppress("UNUSED_PARAMETER")
internal fun getMethodImplForUint8Array(obj: Uint8Array, index: Int): Byte = js("return obj[index];")
private fun getMethodImplForUint8Array(obj: Uint8Array, index: Int): Byte = js("obj[index]")

public operator fun Uint8Array.get(index: Int): Byte = getMethodImplForUint8Array(this, index)

@Suppress("UNUSED_PARAMETER")
internal fun setMethodImplForUint8Array(
private fun setMethodImplForUint8Array(
obj: Uint8Array,
index: Int,
value: Byte
): Unit = js("obj[index] = value;")
): Unit = js("obj[index] = value")

public operator fun Uint8Array.set(index: Int, value: Byte): Unit =
setMethodImplForUint8Array(this, index, value)
Expand All @@ -188,15 +188,15 @@ public external interface ArrayLike<T : JsAny?> : JsAny {
}

@Suppress("UNUSED_PARAMETER")
internal fun <T : JsAny?> getMethodImplForArrayLike(obj: ArrayLike<T>, index: Int): T =
js("return obj[index];")
private fun <T : JsAny?> getMethodImplForArrayLike(obj: ArrayLike<T>, index: Int): T =
js("obj[index]")

public operator fun <T : JsAny?> ArrayLike<T>.get(index: Int): T =
getMethodImplForArrayLike(this, index)

@Suppress("UNUSED_PARAMETER")
internal fun <T : JsAny?> setMethodImplForArrayLike(obj: ArrayLike<T>, index: Int, value: T): Unit =
js("obj[index] = value;")
private fun <T : JsAny?> setMethodImplForArrayLike(obj: ArrayLike<T>, index: Int, value: T): Unit =
js("obj[index] = value")

public operator fun <T : JsAny?> ArrayLike<T>.set(index: Int, value: T): Unit =
setMethodImplForArrayLike(this, index, value)