Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe AGENTS.md documentation file was updated to reorder workflow execution steps, placing test execution before compilation. A new guiding principle stating "Prefer this order to fail fast" was added after the ABI validation step, with minor spacing adjustments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| 1. Tests pass: `./gradlew :module-name:jvmTest` (and other platforms if touched) | ||
| 2. Code compiles: `./gradlew :module-name:assemble` | ||
| 3. Code is formatted and linting passes: run `./gradlew :module-name:formatKotlin`, then `./gradlew :module-name:lintKotlin` | ||
| 4. ABI validated: `./gradlew :module-name:updateLegacyAbi` (if public/protected API changed) |
There was a problem hiding this comment.
We could ask it to use a one-liner (after the list):
./gradlew :module-name:assemble :module-name:<target>Test :module-name:formatKotlin :module-name:lintKotlinWhat do you think?
There was a problem hiding this comment.
I think we can ask it to first run tests and then use a one-liner for assemble, format, and lint
If we use only one one-liner and an error occurs, I guess it will try to rerun all tasks sequentially
Though it's just a guess, and I'll try to experiment with that
There was a problem hiding this comment.
By the way we could add a general rule that when agent needs to run multiple Gradle tasks it should pass all these tasks as arguments to a single ./gradlew command.
|
Meh. CI needs to be started manually as we have unconditional requirement for checks, but this PR contains only *.md changes, so build hasn't started. |
Motivation
Agents first run assemble and then only tests which use more tokens and take more time
Solution