coco:support confidential containers pull image#203
coco:support confidential containers pull image#203HITweihailiuxu wants to merge 1 commit intokuasar-io:mainfrom
Conversation
vmm/task/src/container.rs
Outdated
| .map_or_else(|| Err(other!("can not get image: {:?}", image_rpc::ANNO_K8S_IMAGE_NAME)), | ||
| |name| Ok(name) | ||
| )?; | ||
| debug!("image_name = {:?}", image_name); |
There was a problem hiding this comment.
Do not use variable name in debug info?
Image name: {:?}, Container id: {:?}
vmm/task/src/container.rs
Outdated
| container_id: &str, | ||
| ) -> Result<()> { | ||
| let image_name = annotations.get(image_rpc::ANNO_K8S_IMAGE_NAME) | ||
| .map_or_else(|| Err(other!("can not get image: {:?}", image_rpc::ANNO_K8S_IMAGE_NAME)), |
There was a problem hiding this comment.
Better to have container id with error info, so that it is easier to debug?
Failed to get image name from annotation for container {:?}
vmm/task/src/image_rpc.rs
Outdated
| info!("image_client.config.auth set to: {}", !aa_kbc_params.is_empty()); | ||
| image_client.config.auth = !aa_kbc_params.is_empty(); | ||
|
|
||
| // Read enable signature verification from the task config and set it in the image_client |
There was a problem hiding this comment.
Check if signature verification is enabled, and set it in image client
vmm/task/src/image_rpc.rs
Outdated
| .await; | ||
| match res { | ||
| Ok(image) => { | ||
| info!("pull and unpack image {:?}, cid: {:?}, with image-rs succeed. ", image, cid); |
There was a problem hiding this comment.
Successfully pull and unpack image ..
vmm/task/src/image_rpc.rs
Outdated
| info!("pull and unpack image {:?}, cid: {:?}, with image-rs succeed. ", image, cid); | ||
| } | ||
| Err(e) => { | ||
| error!("pull and unpack image {:?}, cid: {:?}, with image-rs failed with {:?}. ", |
|
@HITweihailiuxu could you address the review comments, and fix the failing checks? |
|
recompile protobuf by env GENERATE_PROTOBUF=1 |
I have modified the code based on the review comments and fixed the original failing checks by adding env GENERATE_PROTOBUF=1. |
HITweihailiuxu
force-pushed
the
coco-dev
branch
3 times, most recently
from
7493578 to
f13230e
Compare
|
/retest |
HITweihailiuxu
force-pushed
the
coco-dev
branch
2 times, most recently
from
54f22f9 to
c174202
Compare
|
It seems the codes has not been |
HITweihailiuxu
force-pushed
the
coco-dev
branch
4 times, most recently
from
8dc3b15 to
0621f54
Compare
Signed-off-by: liuxu <liuxu156@huawei.com>
HITweihailiuxu
force-pushed
the
coco-dev
branch
5 times, most recently
from
a656444 to
1918c38
Compare
fixed |
|
@HITweihailiuxu could you please fix the clippy error of CI? |
There are two types of issues in the access control error report:
I have tried to fix them but failed.I have no idea how to proceed. Could you give me some guidance? |
4 participants
Pull image from remote image registry for confidential containers