Skip to content

Use NonEmpty and avoid unreachable code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2022
Merged

Use NonEmpty and avoid unreachable code #1

merged 2 commits into from
Sep 7, 2022

Conversation

ysangkok
Copy link

@ysangkok ysangkok commented Sep 3, 2022

Follow-up for this comment: haskell#1091 (comment)

kubaneko
kubaneko approved these changes Sep 7, 2022
View reviewed changes
Copy link
Owner

@kubaneko kubaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that makes sense.

I was not sure how to construct ItemIndex with NonEmpty so I forgot about it.

@kubaneko kubaneko merged commit 3a4ebbc into kubaneko:PageRank Sep 7, 2022
kubaneko added a commit that referenced this pull request Sep 18, 2022
@ysangkok @kubaneko
Use NonEmpty (#1)
b9b73cc 
Co-authored-by: Ondřej Kubánek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubaneko kubaneko kubaneko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ysangkok @kubaneko