Add AbstractFixerTestCase::assertRiskiness (#930)

kubawerlos · web-flow · commit bd5f6dc94d71 · 2023-12-23T12:23:09.000Z
diff --git a/tests/Fixer/AbstractFixerTestCase.php b/tests/Fixer/AbstractFixerTestCase.php
@@ -219,4 +219,9 @@ final protected function lintSource(string $source): ?string
 
         return null;
     }
+
+    final protected function assertRiskiness(bool $isRisky): void
+    {
+        self::assertSame($isRisky, $this->fixer->isRisky());
+    }
 }
diff --git a/tests/Fixer/CommentSurroundedBySpacesFixerTest.php b/tests/Fixer/CommentSurroundedBySpacesFixerTest.php
@@ -20,7 +20,7 @@ final class CommentSurroundedBySpacesFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/CommentedOutFunctionFixerTest.php b/tests/Fixer/CommentedOutFunctionFixerTest.php
@@ -31,7 +31,7 @@ public function testConfiguration(): void
 
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/ConstructorEmptyBracesFixerTest.php b/tests/Fixer/ConstructorEmptyBracesFixerTest.php
@@ -20,7 +20,7 @@ final class ConstructorEmptyBracesFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/DataProviderNameFixerTest.php b/tests/Fixer/DataProviderNameFixerTest.php
@@ -38,7 +38,7 @@ public function testConfiguration(): void
 
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     public function testSuccessorName(): void
diff --git a/tests/Fixer/DataProviderReturnTypeFixerTest.php b/tests/Fixer/DataProviderReturnTypeFixerTest.php
@@ -40,7 +40,7 @@ public function notProvider(): array {}
 
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     public function testSuccessorName(): void
diff --git a/tests/Fixer/DataProviderStaticFixerTest.php b/tests/Fixer/DataProviderStaticFixerTest.php
@@ -25,7 +25,7 @@ final class DataProviderStaticFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     public function testSuccessorName(): void
diff --git a/tests/Fixer/DeclareAfterOpeningTagFixerTest.php b/tests/Fixer/DeclareAfterOpeningTagFixerTest.php
@@ -20,7 +20,7 @@ final class DeclareAfterOpeningTagFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/EmptyFunctionBodyFixerTest.php b/tests/Fixer/EmptyFunctionBodyFixerTest.php
@@ -20,7 +20,7 @@ final class EmptyFunctionBodyFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/InternalClassCasingFixerTest.php b/tests/Fixer/InternalClassCasingFixerTest.php
@@ -24,7 +24,7 @@ final class InternalClassCasingFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     public function testSuccessorName(): void
diff --git a/tests/Fixer/IssetToArrayKeyExistsFixerTest.php b/tests/Fixer/IssetToArrayKeyExistsFixerTest.php
@@ -20,7 +20,7 @@ final class IssetToArrayKeyExistsFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/MultilineCommentOpeningClosingAloneFixerTest.php b/tests/Fixer/MultilineCommentOpeningClosingAloneFixerTest.php
@@ -20,7 +20,7 @@ final class MultilineCommentOpeningClosingAloneFixerTest extends AbstractFixerTe
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/MultilinePromotedPropertiesFixerTest.php b/tests/Fixer/MultilinePromotedPropertiesFixerTest.php
@@ -39,7 +39,7 @@ public function testConfiguration(): void
 
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoCommentedOutCodeFixerTest.php b/tests/Fixer/NoCommentedOutCodeFixerTest.php
@@ -20,7 +20,7 @@ final class NoCommentedOutCodeFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoDoctrineMigrationsGeneratedCommentFixerTest.php b/tests/Fixer/NoDoctrineMigrationsGeneratedCommentFixerTest.php
@@ -20,7 +20,7 @@ final class NoDoctrineMigrationsGeneratedCommentFixerTest extends AbstractFixerT
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoDuplicatedArrayKeyFixerTest.php b/tests/Fixer/NoDuplicatedArrayKeyFixerTest.php
@@ -24,7 +24,7 @@ final class NoDuplicatedArrayKeyFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     public function testConfiguration(): void
diff --git a/tests/Fixer/NoDuplicatedImportsFixerTest.php b/tests/Fixer/NoDuplicatedImportsFixerTest.php
@@ -20,7 +20,7 @@ final class NoDuplicatedImportsFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoImportFromGlobalNamespaceFixerTest.php b/tests/Fixer/NoImportFromGlobalNamespaceFixerTest.php
@@ -20,7 +20,7 @@ final class NoImportFromGlobalNamespaceFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoLeadingSlashInGlobalNamespaceFixerTest.php b/tests/Fixer/NoLeadingSlashInGlobalNamespaceFixerTest.php
@@ -20,7 +20,7 @@ final class NoLeadingSlashInGlobalNamespaceFixerTest extends AbstractFixerTestCa
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoNullableBooleanTypeFixerTest.php b/tests/Fixer/NoNullableBooleanTypeFixerTest.php
@@ -20,7 +20,7 @@ final class NoNullableBooleanTypeFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/NoPhpStormGeneratedCommentFixerTest.php b/tests/Fixer/NoPhpStormGeneratedCommentFixerTest.php
@@ -20,7 +20,7 @@ final class NoPhpStormGeneratedCommentFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoReferenceInFunctionDefinitionFixerTest.php b/tests/Fixer/NoReferenceInFunctionDefinitionFixerTest.php
@@ -20,7 +20,7 @@ final class NoReferenceInFunctionDefinitionFixerTest extends AbstractFixerTestCa
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/NoSuperfluousConcatenationFixerTest.php b/tests/Fixer/NoSuperfluousConcatenationFixerTest.php
@@ -24,7 +24,7 @@ final class NoSuperfluousConcatenationFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     public function testConfiguration(): void
diff --git a/tests/Fixer/NoTrailingCommaInSinglelineFixerTest.php b/tests/Fixer/NoTrailingCommaInSinglelineFixerTest.php
@@ -20,7 +20,7 @@ final class NoTrailingCommaInSinglelineFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoUselessCommentFixerTest.php b/tests/Fixer/NoUselessCommentFixerTest.php
@@ -20,7 +20,7 @@ final class NoUselessCommentFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoUselessDirnameCallFixerTest.php b/tests/Fixer/NoUselessDirnameCallFixerTest.php
@@ -20,7 +20,7 @@ final class NoUselessDirnameCallFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoUselessDoctrineRepositoryCommentFixerTest.php b/tests/Fixer/NoUselessDoctrineRepositoryCommentFixerTest.php
@@ -20,7 +20,7 @@ final class NoUselessDoctrineRepositoryCommentFixerTest extends AbstractFixerTes
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoUselessParenthesisFixerTest.php b/tests/Fixer/NoUselessParenthesisFixerTest.php
@@ -20,7 +20,7 @@ final class NoUselessParenthesisFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/NoUselessStrlenFixerTest.php b/tests/Fixer/NoUselessStrlenFixerTest.php
@@ -20,7 +20,7 @@ final class NoUselessStrlenFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/NumericLiteralSeparatorFixerTest.php b/tests/Fixer/NumericLiteralSeparatorFixerTest.php
@@ -25,7 +25,7 @@ final class NumericLiteralSeparatorFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     public function testConfiguration(): void
diff --git a/tests/Fixer/PhpUnitAssertArgumentsOrderFixerTest.php b/tests/Fixer/PhpUnitAssertArgumentsOrderFixerTest.php
@@ -20,7 +20,7 @@ final class PhpUnitAssertArgumentsOrderFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/PhpUnitDedicatedAssertFixerTest.php b/tests/Fixer/PhpUnitDedicatedAssertFixerTest.php
@@ -20,7 +20,7 @@ final class PhpUnitDedicatedAssertFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/PhpUnitNoUselessReturnFixerTest.php b/tests/Fixer/PhpUnitNoUselessReturnFixerTest.php
@@ -20,7 +20,7 @@ final class PhpUnitNoUselessReturnFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertTrue($this->fixer->isRisky());
+        self::assertRiskiness(true);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocArrayStyleFixerTest.php b/tests/Fixer/PhpdocArrayStyleFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocArrayStyleFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocNoIncorrectVarAnnotationFixerTest.php b/tests/Fixer/PhpdocNoIncorrectVarAnnotationFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocNoIncorrectVarAnnotationFixerTest extends AbstractFixerTestCas
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocNoSuperfluousParamFixerTest.php b/tests/Fixer/PhpdocNoSuperfluousParamFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocNoSuperfluousParamFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocOnlyAllowedAnnotationsFixerTest.php b/tests/Fixer/PhpdocOnlyAllowedAnnotationsFixerTest.php
@@ -31,7 +31,7 @@ public function testConfiguration(): void
 
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocParamOrderFixerTest.php b/tests/Fixer/PhpdocParamOrderFixerTest.php
@@ -25,7 +25,7 @@ final class PhpdocParamOrderFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     public function testSuccessorName(): void
diff --git a/tests/Fixer/PhpdocParamTypeFixerTest.php b/tests/Fixer/PhpdocParamTypeFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocParamTypeFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocSelfAccessorFixerTest.php b/tests/Fixer/PhpdocSelfAccessorFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocSelfAccessorFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocSingleLineVarFixerTest.php b/tests/Fixer/PhpdocSingleLineVarFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocSingleLineVarFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocTypesCommaSpacesFixerTest.php b/tests/Fixer/PhpdocTypesCommaSpacesFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocTypesCommaSpacesFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocTypesTrimFixerTest.php b/tests/Fixer/PhpdocTypesTrimFixerTest.php
@@ -21,7 +21,7 @@ final class PhpdocTypesTrimFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PhpdocVarAnnotationToAssertFixerTest.php b/tests/Fixer/PhpdocVarAnnotationToAssertFixerTest.php
@@ -20,7 +20,7 @@ final class PhpdocVarAnnotationToAssertFixerTest extends AbstractFixerTestCase
 {
     public function testIsRisky(): void
     {
-        self::assertFalse($this->fixer->isRisky());
+        self::assertRiskiness(false);
     }
 
     /**
diff --git a/tests/Fixer/PromotedConstructorPropertyFixerTest.php b/tests/Fixer/PromotedConstructorPropertyFixerTest.php
diff --git a/tests/Fixer/ReadonlyPromotedPropertiesFixerTest.php b/tests/Fixer/ReadonlyPromotedPropertiesFixerTest.php
diff --git a/tests/Fixer/SingleSpaceAfterStatementFixerTest.php b/tests/Fixer/SingleSpaceAfterStatementFixerTest.php
diff --git a/tests/Fixer/SingleSpaceBeforeStatementFixerTest.php b/tests/Fixer/SingleSpaceBeforeStatementFixerTest.php
diff --git a/tests/Fixer/StringableInterfaceFixerTest.php b/tests/Fixer/StringableInterfaceFixerTest.php

Original file line number	Diff line number	Diff line change
`@@ -219,4 +219,9 @@ final protected function lintSource(string $source): ?string`
`219`	`219`
`220`	`220`	`return null;`
`221`	`221`	`}`
	`222`	`+`
	`223`	`+ final protected function assertRiskiness(bool $isRisky): void`
	`224`	`+ {`
	`225`	`+ self::assertSame($isRisky, $this->fixer->isRisky());`
	`226`	`+ }`
`222`	`227`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ final class CommentSurroundedBySpacesFixerTest extends AbstractFixerTestCase`
`20`	`20`	`{`
`21`	`21`	`public function testIsRisky(): void`
`22`	`22`	`{`
`23`		`- self::assertFalse($this->fixer->isRisky());`
	`23`	`+ self::assertRiskiness(false);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function testConfiguration(): void`
`31`	`31`
`32`	`32`	`public function testIsRisky(): void`
`33`	`33`	`{`
`34`		`- self::assertTrue($this->fixer->isRisky());`
	`34`	`+ self::assertRiskiness(true);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ final class ConstructorEmptyBracesFixerTest extends AbstractFixerTestCase`
`20`	`20`	`{`
`21`	`21`	`public function testIsRisky(): void`
`22`	`22`	`{`
`23`		`- self::assertFalse($this->fixer->isRisky());`
	`23`	`+ self::assertRiskiness(false);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function testConfiguration(): void`
`38`	`38`
`39`	`39`	`public function testIsRisky(): void`
`40`	`40`	`{`
`41`		`- self::assertTrue($this->fixer->isRisky());`
	`41`	`+ self::assertRiskiness(true);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`public function testSuccessorName(): void`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function notProvider(): array {}`
`40`	`40`
`41`	`41`	`public function testIsRisky(): void`
`42`	`42`	`{`
`43`		`- self::assertTrue($this->fixer->isRisky());`
	`43`	`+ self::assertRiskiness(true);`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`public function testSuccessorName(): void`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ final class DataProviderStaticFixerTest extends AbstractFixerTestCase`
`25`	`25`	`{`
`26`	`26`	`public function testIsRisky(): void`
`27`	`27`	`{`
`28`		`- self::assertTrue($this->fixer->isRisky());`
	`28`	`+ self::assertRiskiness(true);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public function testSuccessorName(): void`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ final class DeclareAfterOpeningTagFixerTest extends AbstractFixerTestCase`
`20`	`20`	`{`
`21`	`21`	`public function testIsRisky(): void`
`22`	`22`	`{`
`23`		`- self::assertFalse($this->fixer->isRisky());`
	`23`	`+ self::assertRiskiness(false);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ final class EmptyFunctionBodyFixerTest extends AbstractFixerTestCase`
`20`	`20`	`{`
`21`	`21`	`public function testIsRisky(): void`
`22`	`22`	`{`
`23`		`- self::assertFalse($this->fixer->isRisky());`
	`23`	`+ self::assertRiskiness(false);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ final class InternalClassCasingFixerTest extends AbstractFixerTestCase`
`24`	`24`	`{`
`25`	`25`	`public function testIsRisky(): void`
`26`	`26`	`{`
`27`		`- self::assertFalse($this->fixer->isRisky());`
	`27`	`+ self::assertRiskiness(false);`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public function testSuccessorName(): void`