Extend PhpdocPropertySortedFixer to support @property-read and -write #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
reviewed
Sep 21, 2025
| * @property-read array $beta | ||
| * @property-write Test $gamma | ||
| * @property bool $alpha | ||
| */ |
There was a problem hiding this comment.
So, will it break a groups of read and write? Can you add a test case with this as input:
/**
* @property-write string $charlie
* @property-write string $foxtrot
* @property-write string $bravo
* @property-read string $echo
* @property-read string $delta
* @property-read string $alfa
*/
There was a problem hiding this comment.
The test is in place. Yes, it will break these groups. To keep the groups intact, you should add a blank line between them:
/**
* @property-write string $charlie
* @property-write string $foxtrot
* @property-write string $bravo
*
* @property-read string $echo
* @property-read string $delta
* @property-read string $alfa
*/# Conflicts: # src/Fixer/PhpdocPropertySortedFixer.php # tests/Fixer/PhpdocPropertySortedFixerTest.php
kilya11
force-pushed
the
phpdoc-sorter-property
branch
from
8375152 to
c922594
Compare
kilya11
changed the title
|
Thank you @kilya11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the full syntax for
@property, see https://docs.phpdoc.org/guide/references/phpdoc/tags/property.htmlHere is a fix to support all of them: