Fixed problem with tests #2314
Open
Fixed problem with tests #2314
+30
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some duplicates problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there were no indices in DB, the same pipeline name was inserted causing for multiple pipelines to exist.
This caused the trigger to call pipeline abcde (example), which was inserted again and again every time the tests ran thus causing a test result to be number of abcde matches in db * 3.
This should not be permitted, and is permitted because the init of db is not with a flag called createIndices set to true.
So, now we generate a new pipeline name for every pipeline for every test.
This change is