Skip to content

fixed load graph when run pipeline #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed load graph when run pipeline #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 34 additions & 26 deletions src/Routes/SidebarRight/AddPipeline/Wizard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,10 @@ const Form = styled(AntdForm)`
export const Body = styled.div`
display: flex;
flex-direction: row;
// overflow-y: scroll;
height: ${props => (props.$isEditState ? '81%' : '81%')};
`;

export const ContenerWizard = styled.div`
// position: relative;
// overflow-x: none;
overflow-y: scroll;
height: 100%;
`;
Expand All @@ -45,33 +42,31 @@ export const ContenerJsonGraph = styled.div`
display: flex;
flex-direction: column;
`;

export const ContenerJsonButton = styled.div`
flex: 1;

overflow-y: scroll;
`;

export const ContenerGraph = styled.div`
position: relative;
flex: 1;
height: -webkit-fill-available;

// overflow-y: scroll;
padding-left: 10px;
`;

export const ButtonSticky = styled(Button)`
right: 0;
position: absolute;
margin-right: 20px;
margin-top: 10px;
z-index:999;
}
right: 0;
position: absolute;
margin-right: 20px;
margin-top: 10px;
z-index: 999;
`;

export const ButtonRun = styled(Button)`
margin-left: 20px;
`;

const stepNames = ['Initial', 'Nodes', 'Options'];
const RunPipelineStepNames = ['Initial', 'Options', 'Nodes Info'];

Expand Down Expand Up @@ -140,9 +135,6 @@ const Wizard = ({
toggle();
}, [persistForm, toggle]);

// check for undefined to avoid removing streaming only fields while initial load
// setIsStreamingPipeline(['stream'].includes(getFieldValue('kind')) || valuesState.kind === 'stream');

const isLastStep = stepIdx === steps.length - 1;

const onPrevious = useCallback(
Expand All @@ -156,24 +148,30 @@ const Wizard = ({
);

useEffect(() => {
setIsStreamingPipeline(
['stream'].includes(getFieldValue('kind')) ||
valuesState.kind === 'stream'
);
const currentKind = getFieldValue('kind') || initialState.kind;
const isStreaming = ['stream'].includes(currentKind);

// if kind is undefined then is value default algorithm
resetKind(undefined);
setIsStreamingPipeline(isStreaming);

// Only reset kind if it's actually undefined
// Don't reset on initial load with valid data to preserve pipeline structure
if (!currentKind) {
resetKind(undefined);
}

// Ensure valuesState is synchronized with initial form state
const currentFormValues = form.getFieldsValue();
if (currentFormValues && Object.keys(currentFormValues).length > 0) {
setValuesState(currentFormValues);
}

setTimeout(() => {
setPageLoaded(true);
}, 500);
setPageLoaded(true);
}, []);

useLayoutEffect(() => {
if (firstUpdateWizard.current) {
firstUpdateWizard.current = false;
} else {
// remove gateway or output option from nodes and reset them to algorithm option
resetKind(
isStreamingPipeline ? ['output', 'hyperparamsTuner'] : ['gateway']
);
Expand Down Expand Up @@ -246,14 +244,24 @@ const Wizard = ({
style={{ boxShadow: '0 0 10px rgba(0, 0, 0, 0.1)' }}>
<Splitter.Panel>
<ContenerGraph>
{valuesState && (
{valuesState &&
valuesState.nodes &&
valuesState.nodes.length > 0 ? (
<GraphPreview
pipeline={valuesState}
isBuildAllFlows={isStreamingPipeline}
isMinified
clickNode={selectNodeFromGraph}
reload={reloadGraphPreview}
/>
) : (
<div style={{ padding: '20px', color: '#999' }}>
{!valuesState
? 'Loading pipeline data...'
: !valuesState.nodes
? 'No nodes defined...'
: 'Waiting for pipeline data...'}
</div>
)}
</ContenerGraph>
</Splitter.Panel>
Expand Down