Remove all sinks except stdout, update packages#6
Merged
csatib02 merged 1 commit intokube-logging:masterfrom Nov 3, 2025
Merged
Remove all sinks except stdout, update packages#6csatib02 merged 1 commit intokube-logging:masterfrom
csatib02 merged 1 commit intokube-logging:masterfrom
Conversation
Signed-off-by: Grzegorz Dziwoki <grzegorz.dziwoki@jamf.com>
pepov
approved these changes
Nov 2, 2025
OverOrion
approved these changes
Nov 3, 2025
csatib02
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on modernizing dependencies, improving error handling, and increasing robustness and clarity in event processing.
The primary changes include upgrading Go and related dependencies, simplifying configuration and sink handling, and making the event processing logic more defensive and informative.
Dependency and Build Modernization:
go.mod,Dockerfile, and GitHub Actions workflow, and updated all major dependencies (including Kubernetes, Prometheus, and Viper) to their latest versions, ensuring improved security, compatibility, and performance. [1] [2] [3]Configuration and Sink Handling:
config.jsonto only use thestdoutsink, removing unused or legacy sink options and reducing complexity.stdoutin the code and made config file loading more robust by logging warnings instead of panicking on missing or invalid configs.RFC5424, flattened JSON, and related dependencies) fromsinks/eventdata.go, further streamlining the codebase. [1] [2]Event Processing Robustness:
addEvent,updateEvent,deleteEvent) to include type checks, nil checks, and more descriptive logging, preventing panics and improving debuggability. [1] [2]shouldProcessEventto centralize logic for determining if an event should be processed based on resource version.Configuration and Resource Version Handling:
Minor Improvements:
ioutilfunctions with modern equivalents. [1] [2]Most Important Changes
Dependency and Build Modernization
go.mod,Dockerfile, and CI workflow. [1] [2] [3]Configuration and Sink Handling
config.jsonto a minimal default (stdoutsink only), removing legacy/unused sink configs.stdoutand made config loading fault-tolerant, logging warnings instead of panicking.sinks/eventdata.go. [1] [2]Event Processing Robustness
shouldProcessEventhelper.Configuration and Resource Version Handling
Minor Improvements
ioutilusage with modern equivalents. [1] [2]