Skip to content

Conversation

@clux
Copy link
Member

@clux clux commented Jul 8, 2025

sanity test of pinned versions in kube for schemars 1 and rust 2024

only thing to test is whether metric timing still works:

warning: relative drop order changing in Rust 2024
    --> src/controller.rs:81:6
     |
63   | #[instrument(skip(ctx, doc), fields(trace_id))]
     |                                               - now the temporary value is dropped here, before the local variables in the block or statement
...
69   |     let _timer = ctx.metrics.reconcile.count_and_measure(&trace_id);
     |         ------
     |         |
     |         `_timer` calls a custom destructor
     |         `_timer` will be dropped later as of Edition 2024

@clux clux marked this pull request as ready for review July 8, 2025 09:39
@clux clux merged commit 28e6d5f into main Jul 8, 2025
8 checks passed
@clux clux deleted the pre-major branch July 8, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant