Add read replica support for Postgres #1580
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // StorageType can be durable (default) or ephemeral | ||
| StorageType StorageType `json:"storageType,omitempty"` | ||
| // Storage to specify how storage shall be used. | ||
| Storage *core.PersistentVolumeClaimSpec `json:"storage,omitempty"` |
Member
There was a problem hiding this comment.
Does it make sense to have different service for each read replica group? In that case we can add a serviceTemplate.
They asked about a feature where read going to a particular replica
| StorageType StorageType `json:"storageType,omitempty"` | ||
| // Storage to specify how storage shall be used. | ||
| Storage *core.PersistentVolumeClaimSpec `json:"storage,omitempty"` | ||
| } |
Member
There was a problem hiding this comment.
we need a field for podPlacementPolicy. needed for distributed stuffs
Member
Author
There was a problem hiding this comment.
Add it. We need it for also placing these pods on Spot instances.
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/kubedb/internal/issues/1372