Skip to content

Conversation

@NishantSinghhhhh
Copy link
Contributor

@NishantSinghhhhh NishantSinghhhhh commented Nov 28, 2025

What this PR does / why we need it:

This PR updates the documentation under docs/proposals/algorithms/lifelong-learning/ to include
a clearer, structured and more complete description of the SAM + SSA based open-world segmentation and
annotation framework integrated into Ianvs.

The documentation now includes:

  • Expanded Background explaining the need for open-world segmentation and lifelong learning
  • Clear Goals and Expected Metrics (mIoU, AP, annotation efficiency, real-world performance)
  • Updated Proposal section describing how SAM + SSA will be used for open-domain annotation
  • Newly added High-Level Architecture section with final flow explanation + system diagram
    • Cloud–Edge feedback loop
    • SAM + SSA auto-segmentation
    • Label Studio based human-in-loop refinement
    • Continual learning retraining cycle
  • Added JPEG architecture diagram → docs/proposals/algorithms/lifelong-learning/images/High_Level_Architecture_SAM.jpeg
  • Reformatted and cleaned the documentation for readability and future additions

This brings the proposal documentation closer to a final structure suitable for review and
future development work in the lifelong-learning annotation module.

Fixes:
Fixes #92

Work Completed ✔

Section Status
Background + Motivation ✔ Updated
Goals & Expected Metrics ✔ Added/Refined
Proposal ✔ Refined
High-Level Architecture ✔ Added + New diagram
System Architecture Overview ✔ Added
Design Details (SAM/SSA/Datasets) ✔ Rewritten for clarity

This PR improves readability, completeness, and structure of the document and takes
the SAM proposal closer to final integration under Ianvs.

@gemini-code-assist
Copy link

Summary of Changes

Hello @NishantSinghhhhh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for the SAM + SSA based open-world segmentation and annotation framework integrated into Ianvs. It provides a more structured and complete description by detailing expected performance metrics, outlining the high-level system architecture with a new diagram, and clarifying the overall proposal. The update aims to prepare the proposal for review and subsequent development work in the lifelong-learning annotation module.

Highlights

  • Expected Metrics Defined: Detailed expected metrics have been added for segmentation quality (mIoU, AP, Boundary Accuracy), annotation efficiency (reduction in manual workload, practical usability), and system performance (stable batch annotation, edge/cloud compatibility, scalability).
  • High-Level Architecture Introduced: A new 'High-Level Architecture' section has been incorporated, providing a comprehensive overview of the system's ongoing loop for annotation and training feedback, including the cloud-edge feedback loop, SAM/SSA auto-segmentation, Label Studio-based human-in-loop refinement, and continual learning retraining cycle.
  • New Architecture Diagram: A JPEG image illustrating the 'High_Level_Architecture_SAM' has been added to visually represent the system's design.
  • Documentation Restructuring: The entire document has been reformatted and re-numbered to improve readability, structure, and logical flow, accommodating the newly added sections and ensuring clarity for future additions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the documentation for the open-world segmentation proposal by adding expected metrics and a high-level system architecture. The changes add structure and clarity. My feedback focuses on improving the professionalism and clarity of the language used in the new sections to align with the standards of technical documentation.

@kubeedge-bot kubeedge-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 28, 2025
…ion framework

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@RONAK-AI647
Copy link
Contributor

@NishantSinghhhhh , to solve the commit issues and CI issues:

  1. Sign off the DCO
  2. reframe the commit , you commit should not include special characters like @ & _ , try using simple and to the goal points.

@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2025
NishantSinghhhhh and others added 2 commits December 10, 2025 11:04
…undation Model Based on Edge-cloud Collaborative Lifelong Learning to Reproduce Open World Object Segmentation

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
…open-world segmentation framework

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
…arity, enhance user flow description, and update future work section for fully automatic annotation.

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@NishantSinghhhhh NishantSinghhhhh changed the title Add expected metrics and system architecture for open-world segmentat… Add expected metrics and system architecture for open-world segmentatioon Dec 10, 2025
@NishantSinghhhhh
Copy link
Contributor Author

@MooreZheng @hsj576 , I have completed my work on this Pull request, can you please review it and tell me if any more changes are required in here

@NishantSinghhhhh NishantSinghhhhh changed the title Add expected metrics and system architecture for open-world segmentatioon Add expected metrics and system architecture for open-world segmentation Dec 24, 2025
…ted content

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@kubeedge-bot
Copy link
Collaborator

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 0183efb Update docs Toward Automatic Image Annotation Algorithm with Large Foundation Model Based on Edge-cloud Collaborative Lifelong Learning to Reproduce Open World Object Segmentation
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NishantSinghhhhh
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NishantSinghhhhh
Copy link
Contributor Author

@hsj576 @MooreZheng , I have restored the previous proposal and added the new file with updated content and image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update for readthedoc

3 participants