-
Notifications
You must be signed in to change notification settings - Fork 105
Add expected metrics and system architecture for open-world segmentation #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @NishantSinghhhhh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for the SAM + SSA based open-world segmentation and annotation framework integrated into Ianvs. It provides a more structured and complete description by detailing expected performance metrics, outlining the high-level system architecture with a new diagram, and clarifying the overall proposal. The update aims to prepare the proposal for review and subsequent development work in the lifelong-learning annotation module. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the documentation for the open-world segmentation proposal by adding expected metrics and a high-level system architecture. The changes add structure and clarity. My feedback focuses on improving the professionalism and clarity of the language used in the new sections to align with the standards of technical documentation.
...on Edge-cloud Collaborative Lifelong Learning to Reproduce Open World Object Segmentation.md
Outdated
Show resolved
Hide resolved
...on Edge-cloud Collaborative Lifelong Learning to Reproduce Open World Object Segmentation.md
Outdated
Show resolved
Hide resolved
…ion framework Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
@NishantSinghhhhh , to solve the commit issues and CI issues:
|
...on Edge-cloud Collaborative Lifelong Learning to Reproduce Open World Object Segmentation.md
Outdated
Show resolved
Hide resolved
docs/proposals/algorithms/lifelong-learning/images/High_Level_Architecture_SAM.jpeg
Outdated
Show resolved
Hide resolved
826120a to
682199a
Compare
…undation Model Based on Edge-cloud Collaborative Lifelong Learning to Reproduce Open World Object Segmentation Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
…open-world segmentation framework Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
682199a to
10dc9f6
Compare
…arity, enhance user flow description, and update future work section for fully automatic annotation. Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
@MooreZheng @hsj576 , I have completed my work on this Pull request, can you please review it and tell me if any more changes are required in here |
…ted content Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NishantSinghhhhh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@hsj576 @MooreZheng , I have restored the previous proposal and added the new file with updated content and image |
What this PR does / why we need it:
This PR updates the documentation under
docs/proposals/algorithms/lifelong-learning/to includea clearer, structured and more complete description of the SAM + SSA based open-world segmentation and
annotation framework integrated into Ianvs.
The documentation now includes:
docs/proposals/algorithms/lifelong-learning/images/High_Level_Architecture_SAM.jpegThis brings the proposal documentation closer to a final structure suitable for review and
future development work in the lifelong-learning annotation module.
Fixes:
Fixes #92
Work Completed ✔
This PR improves readability, completeness, and structure of the document and takes
the SAM proposal closer to final integration under Ianvs.