fix(examples): resolve broken paths in MDIL-SS configuration#366
fix(examples): resolve broken paths in MDIL-SS configuration#366krrish175-byte wants to merge 1 commit intokubeedge:mainfrom
Conversation
Summary of ChangesHello @krrish175-byte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical configuration issues within the MDIL-SS incremental learning algorithm's benchmarking setup. By correcting various broken and hardcoded file paths in the YAML configuration, it enables the successful execution of the MDIL-SS benchmarking job, which was previously non-functional due to these path discrepancies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes broken paths in the MDIL-SS example configuration files. By replacing hardcoded and incorrect paths with proper relative paths, it resolves the issue preventing the benchmarking job from running. The changes are accurate and well-contained. I have one minor suggestion to improve maintainability in one of the YAML files by deduplicating a path.
| - name: "accuracy" | ||
| # the url address of python file | ||
| url: "./examples/class_increment_semantic_segmentation/lifelong_learning_bench/testenv/accuracy.py" | ||
| url: "./examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/testenv/accuracy.py" |
There was a problem hiding this comment.
The URL for accuracy.py is duplicated here and on line 16. To improve maintainability and avoid potential inconsistencies in the future, you could use YAML anchors and aliases to define this URL once and reference it in both places.
For example:
x-accuracy-url: &accuracy_url "./examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/testenv/accuracy.py"
testenv:
# ...
model_eval:
model_metric:
# ...
url: *accuracy_url
# ...
metrics:
- name: "accuracy"
url: *accuracy_url
# ...
What type of PR is this?
/kind bug
What this PR does / why we need it:
The implementation for the MDIL-SS incremental learning algorithm was previously merged in PR #85 under
examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation. However, the YAML configuration files inside that folder contained hardcoded paths belonging to a specific local machine (e.g./home/QXY/dataset/...) and referenced a non-existentclass_increment_semantic_segmentationdirectory.This PR fixes those broken paths by substituting them with the correct relative workspace paths, allowing users to successfully run the MDIL-SS benchmarking job.
Which issue(s) this PR fixes:
Fixes #79