Skip to content

Comments

fix(examples): resolve broken paths in MDIL-SS configuration#366

Open
krrish175-byte wants to merge 1 commit intokubeedge:mainfrom
krrish175-byte:fix/issue-79
Open

fix(examples): resolve broken paths in MDIL-SS configuration#366
krrish175-byte wants to merge 1 commit intokubeedge:mainfrom
krrish175-byte:fix/issue-79

Conversation

@krrish175-byte
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:
The implementation for the MDIL-SS incremental learning algorithm was previously merged in PR #85 under examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation. However, the YAML configuration files inside that folder contained hardcoded paths belonging to a specific local machine (e.g. /home/QXY/dataset/...) and referenced a non-existent class_increment_semantic_segmentation directory.

This PR fixes those broken paths by substituting them with the correct relative workspace paths, allowing users to successfully run the MDIL-SS benchmarking job.

Which issue(s) this PR fixes:

Fixes #79

@gemini-code-assist
Copy link

Summary of Changes

Hello @krrish175-byte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical configuration issues within the MDIL-SS incremental learning algorithm's benchmarking setup. By correcting various broken and hardcoded file paths in the YAML configuration, it enables the successful execution of the MDIL-SS benchmarking job, which was previously non-functional due to these path discrepancies.

Highlights

  • Path Correction: Updated hardcoded and incorrect paths in YAML configuration files for the MDIL-SS incremental learning algorithm, replacing absolute paths with correct relative workspace paths.
  • Functionality Restoration: Resolved references to a non-existent class_increment_semantic_segmentation directory, ensuring the MDIL-SS benchmarking job can now run successfully.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/benchmarkingjob.yaml
    • Updated the testenv path to reflect the correct relative location.
    • Corrected the url for the erfnet_lifelong_learning algorithm.
  • examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/testalgorithms/erfnet/test_algorithm.yaml
    • Modified the url for the BaseModel module to its correct relative path.
    • Adjusted the url for the TaskDefinitionByDomain module.
    • Updated the url for the TaskAllocationByDomain module.
  • examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/testenv/testenv.yaml
    • Replaced hardcoded absolute paths for train_url and test_url with relative paths.
    • Corrected the url for the accuracy.py metric within the model_eval configuration.
    • Updated the url for the accuracy.py metric in the general metrics list.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes broken paths in the MDIL-SS example configuration files. By replacing hardcoded and incorrect paths with proper relative paths, it resolves the issue preventing the benchmarking job from running. The changes are accurate and well-contained. I have one minor suggestion to improve maintainability in one of the YAML files by deduplicating a path.

- name: "accuracy"
# the url address of python file
url: "./examples/class_increment_semantic_segmentation/lifelong_learning_bench/testenv/accuracy.py"
url: "./examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/testenv/accuracy.py"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL for accuracy.py is duplicated here and on line 16. To improve maintainability and avoid potential inconsistencies in the future, you could use YAML anchors and aliases to define this URL once and reference it in both places.

For example:

x-accuracy-url: &accuracy_url "./examples/robot-cityscapes-synthia/lifelong_learning_bench/semantic-segmentation/testenv/accuracy.py"

testenv:
  # ...
  model_eval:
    model_metric:
      # ...
      url: *accuracy_url
  # ...
  metrics:
    - name: "accuracy"
      url: *accuracy_url
    # ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementation of a Class Incremental Learning Algorithm Evaluation System based on Ianvs

1 participant