fix validation UTs

Signed-off-by: Arvind Thirumurugan <[email protected]>

Author: Arvind Thirumurugan

pkg/controllers/updaterun/initialization.go

@@ -250,8 +250,8 @@ func (r *Reconciler) collectScheduledClusters(
 			}
 		} else {
 			if bindingSpec.State != placementv1beta1.BindingStateUnscheduled {
-				stateErr := fmt.Errorf("binding `%s/%s` with old policy snapshot `%s/%s` has state %s, we might observe a transient state, need retry", 
-				binding.GetNamespace() ,binding.GetName(), binding.GetNamespace(), bindingSpec.SchedulingPolicySnapshotName, bindingSpec.State)
+				stateErr := fmt.Errorf("binding `%s/%s` with old policy snapshot `%s/%s` has state %s, we might observe a transient state, need retry",
+					binding.GetNamespace(), binding.GetName(), binding.GetNamespace(), bindingSpec.SchedulingPolicySnapshotName, bindingSpec.State)
 
 				klog.V(2).InfoS("Found a not-unscheduled binding with old policy snapshot, retrying", "binding", bindingRef, "placement", placementKey,
 					"latestPolicySnapshotObj", policySnapshotRef, "stagedUpdateRunObj", updateRunRef)

pkg/controllers/updaterun/validation_test.go

@@ -244,7 +244,7 @@ func TestValidateDeleteStageStatus(t *testing.T) {
 		name                   string
 		updatingStageIndex     int
 		lastFinishedStageIndex int
-		toBeDeletedBindings    []*placementv1beta1.ClusterResourceBinding
+		toBeDeletedBindings    []placementv1beta1.BindingObj
 		deleteStageStatus      *placementv1beta1.StageUpdatingStatus
 		wantErr                error
 		wantUpdatingStageIndex int
@@ -257,12 +257,12 @@ func TestValidateDeleteStageStatus(t *testing.T) {
 		},
 		{
 			name: "validateDeleteStageStatus should return error if there's new to-be-deleted bindings",
-			toBeDeletedBindings: []*placementv1beta1.ClusterResourceBinding{
-				{
+			toBeDeletedBindings: []placementv1beta1.BindingObj{
+				&placementv1beta1.ClusterResourceBinding{
 					ObjectMeta: metav1.ObjectMeta{Name: "binding-1"},
 					Spec:       placementv1beta1.ResourceBindingSpec{TargetCluster: "cluster-1"},
 				},
-				{
+				&placementv1beta1.ClusterResourceBinding{
 					ObjectMeta: metav1.ObjectMeta{Name: "binding-2"},
 					Spec:       placementv1beta1.ResourceBindingSpec{TargetCluster: "cluster-2"},
 				},
@@ -280,8 +280,8 @@ func TestValidateDeleteStageStatus(t *testing.T) {
 			name:                   "validateDeleteStageStatus should not return error if there's fewer to-be-deleted bindings",
 			updatingStageIndex:     -1,
 			lastFinishedStageIndex: -1,
-			toBeDeletedBindings: []*placementv1beta1.ClusterResourceBinding{
-				{
+			toBeDeletedBindings: []placementv1beta1.BindingObj{
+				&placementv1beta1.ClusterResourceBinding{
 					ObjectMeta: metav1.ObjectMeta{Name: "binding-1"},
 					Spec:       placementv1beta1.ResourceBindingSpec{TargetCluster: "cluster-1"},
 				},
@@ -300,8 +300,8 @@ func TestValidateDeleteStageStatus(t *testing.T) {
 			name:                   "validateDeleteStageStatus should not return error if there are equal to-be-deleted bindings",
 			updatingStageIndex:     -1,
 			lastFinishedStageIndex: -1,
-			toBeDeletedBindings: []*placementv1beta1.ClusterResourceBinding{
-				{
+			toBeDeletedBindings: []placementv1beta1.BindingObj{
+				&placementv1beta1.ClusterResourceBinding{
 					ObjectMeta: metav1.ObjectMeta{Name: "binding-1"},
 					Spec:       placementv1beta1.ResourceBindingSpec{TargetCluster: "cluster-1"},
 				},