feat: Add ambient mode support to profile-controller (clone)#185
Open
kimwnasptd wants to merge 12 commits intokubeflow:mainfrom
Open
feat: Add ambient mode support to profile-controller (clone)#185kimwnasptd wants to merge 12 commits intokubeflow:mainfrom
kimwnasptd wants to merge 12 commits intokubeflow:mainfrom
Conversation
kimwnasptd
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
- Fix HTTPRoute hostname validation (*.kubeflow.local to kubeflow.local) - Add ambient mode CLI arguments to manager container - Disable sidecar injection for ambient deployments - Separate KFAM and manager container arguments - Add SERVICE_MESH_MODE environment variable support Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
kimwnasptd
force-pushed
the
feat-kimwnasptd-pr-127-extended
branch
from
241d593 to
ae53a68
Compare
Member
Author
|
I'm also getting the @juliusvonkohout do you know how to debug this? |
Member
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
@juliusvonkohout the PR is already based on top of latest EDIT: I closed and re-opened the PR and this seemed to do the trick... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clone of the existing PR #127 plus the fixes from #127 (comment), so that the AuthorizationPolicy gets attached to the waypoint (L7 traffic).
The PR also bumps the golang version, as it's needed to use the latest Istio module version (for using
targetRefs).@madmecodes I'm happy to drop this PR, if we resolve the last comment on the other one. Otherwise let's move on with this PR to ensure we close the loop.
/cc @juliusvonkohout @madmecodes