Skip to content

refactor(dashboard): update kustomize manifests structure as per notebooks v2#189

Open
alokdangre wants to merge 2 commits intokubeflow:mainfrom
alokdangre:refactor/centraldashboard-manifests
Open

refactor(dashboard): update kustomize manifests structure as per notebooks v2#189
alokdangre wants to merge 2 commits intokubeflow:mainfrom
alokdangre:refactor/centraldashboard-manifests

Conversation

@alokdangre
Copy link

  • Move common labels to components/common
  • Move network-policy to istio component
  • Use envFrom with configMapRef in deployment
  • Move sidecar injection to istio patch
  • Move replacements to overlays
  • Enable nameSuffixHash for ConfigMaps

related: #180

Directory Structure

kustomize/
├── base/
│ ├── clusterrole-binding.yaml
│ ├── clusterrole.yaml
│ ├── configmap.yaml
│ ├── deployment.yaml
│ ├── kustomization.yaml
│ ├── params.env
│ ├── role-binding.yaml
│ ├── role.yaml
│ ├── service-account.yaml
│ └── service.yaml
├── components/
│ ├── common/
│ │ └── kustomization.yaml # NEW: Contains all labels
│ └── istio/
│ ├── authorizationpolicy.yaml
│ ├── kustomization.yaml # Updated: sidecar patch, network-policy
│ ├── network-policy.yaml # MOVED from base
│ └── virtual-service.yaml
└── overlays/
├── istio/
│ └── kustomization.yaml # Updated: has all replacements
└── kserve/
├── kustomization.yaml # Updated: has all replacements
└── patches/
└── configmap.yaml

Signed-off-by: alokdangre <alokdangre@gmail.com>
- Move common labels to components/common- Move network-policy to istio component- Use envFrom with configMapRef in deployment- Move sidecar injection to istio patch- Move replacements to overlays- Enable nameSuffixHash for ConfigMaps

Signed-off-by: alokdangre <alokdangre@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alokdangre alokdangre changed the title Refactored centraldashboard manifests as per notebooks v2 refactor(dashboard): update kustomize manifests structure as per notebooks v2 Feb 2, 2026
@alokdangre alokdangre marked this pull request as ready for review February 2, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant