-
Notifications
You must be signed in to change notification settings - Fork 1k
Add various Helm charts POCs #3154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kunal-511
wants to merge
20
commits into
kubeflow:master
from
kunal-511:feat/helm-spark-operator-with-verification
Closed
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
880c28c
Helm chart support for Kubeflow spark-operator
kunal-511 1dc5372
Updated permission and formatting
kunal-511 9fdb2d2
Added the helm sync script for spark-operator
kunal-511 9bdb472
Added the spark sync script and updated the strucute according to AIO
kunal-511 66f88d9
Updated the name
kunal-511 3fb12ec
Updated the comparision
kunal-511 ecc1ed9
helm chart test updated
kunal-511 00c6e96
helm charts script for cert-manager
kunal-511 5f0be99
Handling the crds correctly in helm folder strucuture
kunal-511 89a77b0
Added central dashboard helm templates
kunal-511 3de1913
Updated the path to applications
kunal-511 0683d18
Updated to applications
kunal-511 eb966fa
Updated script permissions
kunal-511 a00a521
Helm install a particular version
kunal-511 585a558
Updated comparision to remove other crds when comparing
kunal-511 54bde97
Spark-operator and cert-manager files from sync scripts
kunal-511 69e6b90
removed the helm templates generated from the sync script
kunal-511 47eb3d0
removed the helm templates generated from the sync script
kunal-511 fd26144
Removed the combination of the charts
kunal-511 a415803
Updated the workflow
kunal-511 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Test Helm Charts | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - experimental/helm/kubeflow/** | ||
| - experimental/helm/scripts/** | ||
| - .github/workflows/helm_charts_test.yaml | ||
|
|
||
| jobs: | ||
| test-helm-charts: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Helm | ||
| run: | | ||
| ./tests/helm_install.sh | ||
|
|
||
| - name: Run Helm Chart Tests | ||
| run: | | ||
| cd experimental/helm | ||
| ./scripts/test-helm-charts.sh | ||
|
|
||
| - name: Upload artifacts on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: helm-test-logs | ||
| path: /tmp/helm-test-*.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Verify Helm vs Kustomize Manifests | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| - tests/helm_install.sh | ||
| - .github/workflows/helm_vs_kustomize_verification.yaml | ||
| - apps/spark/spark-operator/** | ||
| - apps/centraldashboard/** | ||
| - common/cert-manager/** | ||
| - experimental/helm/kubeflow/** | ||
| - experimental/helm/scripts/** | ||
| - tests/helm_kustomize_compare_manifests.sh | ||
| - tests/helm_kustomize_compare_manifests.py | ||
|
|
||
| jobs: | ||
| verify-components: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| strategy: | ||
| matrix: | ||
| component: [spark-operator, cert-manager, centraldashboard, centraldashboard-istio, centraldashboard-kserve, centraldashboard-oauth2-proxy] | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install KinD, Create KinD cluster and Install kustomize | ||
| run: | | ||
| chmod +x tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
| ./tests/install_KinD_create_KinD_cluster_install_kustomize.sh | ||
|
|
||
| - name: Install Helm | ||
| run: | | ||
| chmod +x tests/helm_install.sh | ||
| ./tests/helm_install.sh | ||
|
|
||
| - name: Run Helm vs Kustomize verification for ${{ matrix.component }} | ||
| run: | | ||
| chmod +x tests/helm_kustomize_compare_manifests.sh | ||
| ./tests/helm_kustomize_compare_manifests.sh ${{ matrix.component }} | ||
|
|
||
| - name: Upload artifacts on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ matrix.component }}-manifest-comparison-artifacts | ||
| path: | | ||
| /tmp/kustomize-${{ matrix.component }}.yaml | ||
| /tmp/helm-aio-${{ matrix.component }}.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Helm dependency charts | ||
| **/charts/*.tgz | ||
| **/Chart.lock | ||
|
|
||
| # Helm temporary files | ||
| *.tmp | ||
| *.backup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| apiVersion: v2 | ||
| name: kubeflow | ||
| description: All-in-One Helm chart for deploying Kubeflow Platform | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "1.10.0" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| {{/* | ||
| Expand the name of the chart. | ||
| */}} | ||
| {{- define "kubeflow.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| */}} | ||
| {{- define "kubeflow.fullname" -}} | ||
| {{- if .Values.fullnameOverride }} | ||
| {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- $name := default .Chart.Name .Values.nameOverride }} | ||
| {{- if contains $name .Release.Name }} | ||
| {{- .Release.Name | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create chart name and version as used by the chart label. | ||
| */}} | ||
| {{- define "kubeflow.chart" -}} | ||
| {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Common labels | ||
| */}} | ||
| {{- define "kubeflow.labels" -}} | ||
| helm.sh/chart: {{ include "kubeflow.chart" . }} | ||
| {{ include "kubeflow.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Selector labels | ||
| */}} | ||
| {{- define "kubeflow.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "kubeflow.name" . }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Get the namespace for Kubeflow components | ||
| */}} | ||
| {{- define "kubeflow.namespace" -}} | ||
| {{- .Values.global.kubeflowNamespace | default "kubeflow" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Get the namespace for Istio components | ||
| */}} | ||
| {{- define "kubeflow.istioNamespace" -}} | ||
| {{- .Values.global.istioNamespace | default "istio-system" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Get the namespace for cert-manager components | ||
| */}} | ||
| {{- define "kubeflow.certManagerNamespace" -}} | ||
| {{- .Values.global.certManagerNamespace | default "cert-manager" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Get the domain for Kubeflow | ||
| */}} | ||
| {{- define "kubeflow.domain" -}} | ||
| {{- .Values.global.domain | default "example.com" }} | ||
| {{- end }} |
22 changes: 22 additions & 0 deletions
22
experimental/helm/kubeflow/templates/applications/centraldashboard/authorizationpolicy.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| {{- if and .Values.centraldashboard.enabled .Values.centraldashboard.istio.enabled }} | ||
| apiVersion: security.istio.io/v1beta1 | ||
| kind: AuthorizationPolicy | ||
| metadata: | ||
| name: central-dashboard | ||
| namespace: {{ .Values.global.kubeflowNamespace }} | ||
| labels: | ||
| app: centraldashboard | ||
| app.kubernetes.io/component: centraldashboard | ||
| app.kubernetes.io/name: centraldashboard | ||
| kustomize.component: centraldashboard | ||
| spec: | ||
| action: ALLOW | ||
| rules: | ||
| - from: | ||
| - source: | ||
| principals: | ||
| - cluster.local/ns/{{ .Values.global.istioNamespace }}/sa/istio-ingressgateway-service-account | ||
| selector: | ||
| matchLabels: | ||
| app: centraldashboard | ||
| {{- end }} |
22 changes: 22 additions & 0 deletions
22
experimental/helm/kubeflow/templates/applications/centraldashboard/clusterrole.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| {{- if .Values.centraldashboard.enabled }} | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: centraldashboard | ||
| labels: | ||
| app: centraldashboard | ||
| app.kubernetes.io/component: centraldashboard | ||
| app.kubernetes.io/name: centraldashboard | ||
| kustomize.component: centraldashboard | ||
| rules: | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - events | ||
| - namespaces | ||
| - nodes | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| {{- end }} |
19 changes: 19 additions & 0 deletions
19
experimental/helm/kubeflow/templates/applications/centraldashboard/clusterrolebinding.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| {{- if .Values.centraldashboard.enabled }} | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: centraldashboard | ||
| labels: | ||
| app: centraldashboard | ||
| app.kubernetes.io/component: centraldashboard | ||
| app.kubernetes.io/name: centraldashboard | ||
| kustomize.component: centraldashboard | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: centraldashboard | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: centraldashboard | ||
| namespace: {{ .Values.global.kubeflowNamespace }} | ||
| {{- end }} |
18 changes: 18 additions & 0 deletions
18
experimental/helm/kubeflow/templates/applications/centraldashboard/configmap-parameters.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| {{- if .Values.centraldashboard.enabled }} | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: centraldashboard-parameters | ||
| namespace: {{ .Values.global.kubeflowNamespace }} | ||
| labels: | ||
| app: centraldashboard | ||
| app.kubernetes.io/component: centraldashboard | ||
| app.kubernetes.io/name: centraldashboard | ||
| kustomize.component: centraldashboard | ||
| data: | ||
| CD_CLUSTER_DOMAIN: {{ .Values.centraldashboard.config.clusterDomain | quote }} | ||
| CD_USERID_HEADER: {{ .Values.centraldashboard.config.useridHeader | quote }} | ||
| CD_USERID_PREFIX: {{ .Values.centraldashboard.config.useridPrefix | quote }} | ||
| CD_REGISTRATION_FLOW: {{ .Values.centraldashboard.config.registrationFlow | quote }} | ||
| CD_COLLECT_METRICS: {{ .Values.centraldashboard.config.collectMetrics | quote }} | ||
| {{- end }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master instead of 1.10.0 i assume