Skip to content

Documentation fix #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pradyumn-cloud wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Documentation fix #3257

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
206f6d9
Documentation fix
Pradyumn-cloud Oct 10, 2025
7fe4cde
further changes in doc file
Pradyumn-cloud Oct 10, 2025
57757fc
Adding required comments
Pradyumn-cloud Oct 10, 2025
f16b1f1
Add DCO sign-off for previous commit
Pradyumn-cloud Oct 22, 2025
e856e76
new changes
Pradyumn-cloud Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion common/dex/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ data:
clientID: $CLIENT_ID
clientSecret: $CLIENT_SECRET
redirectURI: $REDIRECT_URI
insecure: false
# Set to true only for self-signed certificates. See: https://dexidp.io/docs/connectors/oidc/
Copy link
Member

@juliusvonkohout juliusvonkohout Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see "insecureSkipVerify" on the page you linked

Copy link
Member

@juliusvonkohout juliusvonkohout Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and an inline comment would be insecureSkipVerify: false # Set to true only for self-signed certificates. See: https://dexidp.io/docs/connectors/oidc/ in a single line

Copy link
Member

@juliusvonkohout juliusvonkohout Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insecureSkipVerify: false # Specify whether to communicate with the authentication provider without validating SSL certificates see https://dexidp.io/docs/connectors/oauth/ and https://dexidp.io/docs/connectors/oidc/

would be my guess but on the pages linked i see it in the oauth instead of the oidc section. CC @kromanow94 @kimwnasptd for more input

Copy link
Author

@Pradyumn-cloud Pradyumn-cloud Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oidc doc dont mention insecureSkipVerify instead oauth2.0 do.

So i am adding this line - insecureSkipVerify: false # Specify whether to communicate with the authentication provider without validating SSL certificates see https://dexidp.io/docs/connectors/oauth/ and https://dexidp.io/docs/connectors/oidc/.

Copy link
Member

@juliusvonkohout juliusvonkohout Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you are modyfying it under the oidc section. I still do not see proof, that this is the right location. Did you test this on a real cluster?

insecureSkipVerify: false
insecureSkipEmailVerified: true
userNameKey: email
scopes:
Expand Down
Loading