-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove seccompProfile from trainer deployment securityContext #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
andreyvelich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juliusvonkohout!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
@andreyvelich I have the same problem with katib-ui
|
That means right now the patch is still needed at the pod level and should be upstreamed to katib. |
@andreyvelich since there now is https://github.com/kubeflow/trainer/blob/588f2ae4f9522f82c64138013e71e62073a1cd6f/manifests/base/manager/manager.yaml#L32-L33 and we have istio sidecars with seccompprofile:default