-
Notifications
You must be signed in to change notification settings - Fork 154
feat: enable standalone UI in docker-compose with configurable deployment mode #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ment mode Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
|
@tarilabs better late than never 😅 |
lucferbux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits but there's the part of adding env-test to the dockerfile, we should avoid that at all costs, maybe we might wanna explore having an extra dockerfile or smth similar.
Address PR review feedback from @lucferbux: - Create dedicated Dockerfile.standalone with envtest support to avoid bloating production image with K8s test binaries (~150MB) - Keep main Dockerfile clean for kubeflow/federated deployments - Update docker-compose.yaml to use ui-standalone image - Add explicit --mock-mr-client=false and --mock-mr-catalog-client=false flags for better readability - Update Makefile and GitHub workflow to use new Dockerfile - Document Dockerfile structure in README Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
|
@lucferbux ready for another round! |
lucferbux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
@tarilabs, when you have a chance, could you please take a look at it? |
tarilabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @ederign and @lucferbux
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add deployment mode and style theme as parameters to the UI Dockerfile, enable
--mock-k8s-client=truefor standalone mode, and integrate the UI service into docker-compose for running the complete local development stack.Closes #2055 .
Changes
DEPLOYMENT_MODEandSTYLE_THEMEas build arguments to UI Dockerfile--mock-k8s-client=truein the standalone Docker imagemodel-registry-uiservice todocker-compose.yaml(pre-built images)model-registry-uiservice todocker-compose-local.yaml(builds from source)extra_hosts: localhost:host-gatewayto route BFF connections to model-registry and model-catalog containersAfter PR review:
bloating production image with K8s test binaries (~150MB)
flags for better readability
Usage
How Has This Been Tested?
Verified UI successfully fetches data from both model-registry and model-catalog via the host-gateway routing.
make compose/local/up/postgres
make compose/up/postgres
Kapture.2026-01-03.at.13.03.17.mp4
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.