Always pass perf filters to card artifacts call for correct benchmark counts regardless of toggle state

[manaswinidas]

Description

Now the benchmark counts are same whether the performance filters toggle is ON or OFF

Added a Cypress test and edited mocks

How Has This Been Tested?

Tested midstream - On the model catalog landing page cards, benchmark counts on “View N benchmarks” links should be the same both without the toggle enabled and with the toggle enabled (while filters are set to default), and be the same as the number of benchmarks as seen on the details page with default filters applied.

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages
• Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.
• For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

• The developer has added tests or explained why testing cannot be added.
• Included any necessary screenshots or gifs if it was a UI change.
• Verify that UI/UX changes conform the UX guidelines for Kubeflow.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from manaswinidas. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• clients/ui/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ppadti]

I tested this locally, but I am not seeing the the default perf filters being passed on performance endpoint on load. I think Its because on load, filterData in context is empty so no filterQuery is being passed.

[mturley]

+1 to @ppadti 's comment - right now the default perf filter values don't end up in state until the first time the perf view toggle is turned on. we might just want to change that behavior so we put those perf filter defaults in state as soon as the page loads. That should be safe now that we have excluded those elsewhere when the toggle is off.

[mturley]

Hm, I wonder if we should only have this trigger if there are no perf filters in state (or maybe if at least one of the filters present in namedQueries has no value in state) so we don't accidentally reset them to defaults when filter options are fetched again