Model Catalog chips enhancements#2214
Conversation
|
/retest |
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
c016133 to
095b8d3
Compare
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
|
@manaswinidas |
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
| {onResetAllFilters && hasVisibleChips && ( | ||
| <ToolbarItem> | ||
| <Button | ||
| variant="link" | ||
| onClick={onResetAllFilters} | ||
| data-testid="clear-all-filters-button" | ||
| > | ||
| Reset all defaults | ||
| </Button> | ||
| </ToolbarItem> |
There was a problem hiding this comment.
Since you're using a combination of custom-rendered chips and ToolbarFilter chips, if both are rendered at the same time we have both this "Reset all defaults" link and the built-in "Clear all filters" one that is provided by Toolbar when there are active ToolbarFilters under it. If we're no longer relying only on the built-in ToolbarFilter component, we should force the built-in one to never render (I think we might be able to do that by passing empty values into Toolbar, like we conditionally did before above on line 100). If that doesn't work... we may need to abandon using the built in ToolbarFilter chips. The intention was to use only those because we wanted to avoid custom rendering, but it seems that's not possible. If we cause ourselves too much more pain here maybe we should entirely render only custom chips for everything.
Another thing we lose by combining the built-in with custom chips is that they appear on two separate lines, and your custom ones are wrapping starting to the right of the toolbar controls which isn't right, they should all be below the toolbar.
Also, the chips not in a group are not vertically centered with the chips that are in a group. This is true in both themes but more visible in the MUI theme. The MUI theme also has color issues, with white icons on grey chips.
Finally, for your latency filter chip group, the reset icon is appearing outside the group and larger rather than within the group as it should, at the same size as the other icons.
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
|
/lmao |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Description
Enhanced the filter chip display and behavior on the Model Catalog landing page to improve UX consistency and clarity:
How Has This Been Tested?
Manual Testing Required:
Performance View Toggle
Workload Type Chip
"Scenario: {Name} ({X} input / {Y} output tokens)"Latency Chip Group
Max RPS Chip
"Max RPS: {value}"Hardware Chips
Side Panel Filters (License, Provider, etc.)
Reset All Filters Button
Screen.Recording.2026-02-10.at.1.50.49.PM.mov
Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.If you have UI changes: