-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(CI): Reduces CI time. Fixes #11768 #12093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2242407 to
b2bfd4c
Compare
a7fbdc3 to
3ca5783
Compare
75d514c to
fc1fc13
Compare
b91743e to
e5913fb
Compare
70d3891 to
2404eac
Compare
5760c87 to
37e9528
Compare
…ent modules as matrix
- Uploading generated docker image tarball as an artifact (with 1 day of retention) with path as "images_${last commit sha}"
- Downloading the tar ball during the deployment step and loading it to kind cluster
- Fixing minor warnings by parsing the CMD command as a string array
Signed-off-by: Nelesh Singla <[email protected]>
hbelmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Uploading generated docker image tarball as an artifact (with 1 day of retention) with path as "images_${last commit sha}"
- Downloading the tar ball during the deployment step and loading it to kind cluster
- Fixing minor warnings by parsing the CMD command as a string array
Signed-off-by: Nelesh Singla <[email protected]>
| required: false | ||
| default: 'true' | ||
|
|
||
| cluser_name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nsingla
I came across this file and spotted a typo here. I guess t is missing. Should it be cluster_name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, thanks for catching it, I will raise a PR to fix this shortly
build_images.shscriptChecklist:
Notes