Skip to content

Conversation

@nsingla
Copy link
Contributor

@nsingla nsingla commented Jul 31, 2025

  • Parallelizing docker builds by running a build workflow with different modules as matrix
  • Uploading generated docker image tarball as an artifact (with 1 day of retention) with path as "images_${last commit sha}"
  • Downloading the tar ball during the deployment step and loading it to kind cluster
  • Fixing following minor warnings by parsing the CMD command as a string array:
3 warnings found (use docker --debug to expand):
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 84)
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 47)
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 53)
  • By doing this, we've reduce the CI time by ~50%
  • Delete now unused build_images.sh script

Checklist:

Notes

  • Follow up PR is required to generate outputs from the build jobs to list the deployed apps and the artifact directory where the artifacts were uploaded, so that we don;t need to hardcode these values in 2 places

@nsingla nsingla force-pushed the 11768 branch 2 times, most recently from 2242407 to b2bfd4c Compare July 31, 2025 19:26
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Jul 31, 2025
@nsingla nsingla force-pushed the 11768 branch 2 times, most recently from a7fbdc3 to 3ca5783 Compare August 1, 2025 15:37
@nsingla nsingla force-pushed the 11768 branch 7 times, most recently from 75d514c to fc1fc13 Compare August 5, 2025 18:18
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Aug 5, 2025
@nsingla nsingla force-pushed the 11768 branch 2 times, most recently from b91743e to e5913fb Compare August 5, 2025 19:31
@nsingla nsingla force-pushed the 11768 branch 12 times, most recently from 70d3891 to 2404eac Compare August 6, 2025 18:44
@nsingla nsingla force-pushed the 11768 branch 6 times, most recently from 5760c87 to 37e9528 Compare August 7, 2025 19:07
…ent modules as matrix

- Uploading generated docker image tarball as an artifact (with 1 day of retention) with path as "images_${last commit sha}"
- Downloading the tar ball during the deployment step and loading it to kind cluster
- Fixing  minor warnings by parsing the CMD command as a string array

Signed-off-by: Nelesh Singla <[email protected]>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c11a735 into kubeflow:master Aug 7, 2025
63 checks passed
kaikaila pushed a commit to kaikaila/kubeflow-pipelines that referenced this pull request Aug 7, 2025
- Uploading generated docker image tarball as an artifact (with 1 day of retention) with path as "images_${last commit sha}"
- Downloading the tar ball during the deployment step and loading it to kind cluster
- Fixing  minor warnings by parsing the CMD command as a string array

Signed-off-by: Nelesh Singla <[email protected]>
required: false
default: 'true'

cluser_name:
Copy link
Contributor

@kaikaila kaikaila Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nsingla
I came across this file and spotted a typo here. I guess t is missing. Should it be cluster_name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, thanks for catching it, I will raise a PR to fix this shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants