Skip to content

Conversation

@vmridul
Copy link

@vmridul vmridul commented Dec 19, 2025

Summary
Added support for PVC subPath mounting in Kubeflow Pipelines by passing an optional sub_path parameter to the PVC mount function, enabling users to mount a specific folder within a PVC.

Key Implementation Details

  1. Protobuf Definition:
    Added sub_path field to PvcMount message in kubernetes_executor_config.proto
    Regenerated Python and Go protobuf code to support the new field

  2. Python SDK Enhancement:
    Updated mount_pvc() function in kfp/kubernetes/volume.py to accept optional sub_path parameter
    Maintains backward compatibility with default None value
    Passes sub_path to protobuf message creation

  3. Backend Integration:
    Modified makeVolumeMountPatch() in backend/src/v2/driver/k8s.go to read sub_path from protobuf
    Passes SubPath to Kubernetes VolumeMount struct
    Leverages native Kubernetes subPath support

  4. Test Coverage:
    Added Python unit test: test_mount_pvc_with_subpath
    Added Go unit test: test case for pvc_with_subPath
    All existing tests continue to pass

Checklist:

@google-oss-prow
Copy link

Hi @vmridul. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vmridul vmridul force-pushed the add-subpath-support branch 2 times, most recently from 1b86726 to bdb43e7 Compare December 19, 2025 11:46
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmridul There are several changes in this PR that seem unrelated to the description. For example, GitHub workflows and a downgrade of envoyproxy/envoy in a Dockerfile.

@vmridul
Copy link
Author

vmridul commented Dec 19, 2025

Apologies for the confusion, and thanks for flagging this. I’m new to contributing here, and those changes were accidentally picked up during my local workflow, they’re not intentional and not related to the PVC subPath work.

I’ll correct the PR so it only contains the relevant changes.

@vmridul vmridul force-pushed the add-subpath-support branch from bdb43e7 to 3a96f57 Compare December 19, 2025 15:53
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hbelmiro. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vmridul vmridul requested a review from hbelmiro December 19, 2025 17:26
@droctothorpe
Copy link
Collaborator

/ok-to-test

@vmridul vmridul force-pushed the add-subpath-support branch from c661af0 to 092ba35 Compare December 24, 2025 07:47
Signed-off-by: Mridul verma <[email protected]>
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmridul can you please link the PR to the issues and rebase?

@hbelmiro
Copy link
Contributor

@vmridul nevermind. Another PR that fixes the same issue was merged.
Closing in favor of #12595.
/close

@google-oss-prow google-oss-prow bot closed this Dec 30, 2025
@google-oss-prow
Copy link

@hbelmiro: Closed this PR.

Details

In response to this:

@vmridul nevermind. Another PR that fixes the same issue was merged.
Closing in favor of #12595.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants