-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(backend): add subPath support for PVC mounts. Fixes #11832 #12565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @vmridul. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1b86726 to
bdb43e7
Compare
hbelmiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmridul There are several changes in this PR that seem unrelated to the description. For example, GitHub workflows and a downgrade of envoyproxy/envoy in a Dockerfile.
|
Apologies for the confusion, and thanks for flagging this. I’m new to contributing here, and those changes were accidentally picked up during my local workflow, they’re not intentional and not related to the PVC subPath work. I’ll correct the PR so it only contains the relevant changes. |
bdb43e7 to
3a96f57
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: vmridul <[email protected]>
57864e4 to
334e414
Compare
|
/ok-to-test |
Signed-off-by: Mridul verma <[email protected]>
c661af0 to
092ba35
Compare
Signed-off-by: Mridul verma <[email protected]>
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmridul can you please link the PR to the issues and rebase?
|
@hbelmiro: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
Added support for PVC subPath mounting in Kubeflow Pipelines by passing an optional sub_path parameter to the PVC mount function, enabling users to mount a specific folder within a PVC.
Key Implementation Details
Protobuf Definition:
Added sub_path field to PvcMount message in kubernetes_executor_config.proto
Regenerated Python and Go protobuf code to support the new field
Python SDK Enhancement:
Updated mount_pvc() function in kfp/kubernetes/volume.py to accept optional sub_path parameter
Maintains backward compatibility with default None value
Passes sub_path to protobuf message creation
Backend Integration:
Modified makeVolumeMountPatch() in backend/src/v2/driver/k8s.go to read sub_path from protobuf
Passes SubPath to Kubernetes VolumeMount struct
Leverages native Kubernetes subPath support
Test Coverage:
Added Python unit test: test_mount_pvc_with_subpath
Added Go unit test: test case for pvc_with_subPath
All existing tests continue to pass
Checklist: