chore(test): use make in kfp-kubernetes-library-test.yml. Fixes #11691#12738
chore(test): use make in kfp-kubernetes-library-test.yml. Fixes #11691#12738puwun wants to merge 1 commit intokubeflow:masterfrom
kfp-kubernetes-library-test.yml. Fixes #11691#12738Conversation
…low#11691 Signed-off-by: Pavan More <pavansmore05@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @puwun. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR adds a Makefile target for running kfp-kubernetes library tests and updates the GitHub Actions workflow to use this target instead of calling pytest directly. This change addresses issue #11691 by centralizing the test command in the Makefile, making it easier to maintain and run tests consistently across different environments.
Changes:
- Added
test-kfp-kubernetestarget to the root Makefile - Updated the kfp-kubernetes-library-test workflow to use
make test-kfp-kubernetes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Adds a new test-kfp-kubernetes target that runs pytest on the kubernetes_platform/python/test directory |
| .github/workflows/kfp-kubernetes-library-test.yml | Updates the test execution step to use the new Makefile target instead of direct pytest command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/ok-to-test |
Description of your changes:
test-kfp-kubernetestarget toMakefilemake test-kfp-kubernetesChecklist: