Skip to content

chore(test): use make in kfp-kubernetes-library-test.yml. Fixes #11691#12738

Open
puwun wants to merge 1 commit intokubeflow:masterfrom
puwun:chore/kfp-kubernetes-make-11691
Open

chore(test): use make in kfp-kubernetes-library-test.yml. Fixes #11691#12738
puwun wants to merge 1 commit intokubeflow:masterfrom
puwun:chore/kfp-kubernetes-make-11691

Conversation

@puwun
Copy link

@puwun puwun commented Jan 30, 2026

Description of your changes:

  • Added test-kfp-kubernetes target to Makefile
  • Updated workflow to use make test-kfp-kubernetes

Checklist:

…low#11691

Signed-off-by: Pavan More <pavansmore05@gmail.com>
Copilot AI review requested due to automatic review settings January 30, 2026 13:04
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @puwun. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Makefile target for running kfp-kubernetes library tests and updates the GitHub Actions workflow to use this target instead of calling pytest directly. This change addresses issue #11691 by centralizing the test command in the Makefile, making it easier to maintain and run tests consistently across different environments.

Changes:

  • Added test-kfp-kubernetes target to the root Makefile
  • Updated the kfp-kubernetes-library-test workflow to use make test-kfp-kubernetes

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Makefile Adds a new test-kfp-kubernetes target that runs pytest on the kubernetes_platform/python/test directory
.github/workflows/kfp-kubernetes-library-test.yml Updates the test execution step to use the new Makefile target instead of direct pytest command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 2, 2026

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants