Skip to content

chore(test): use make commands in sdk-component-yaml. Fixes #11698#12755

Open
puwun wants to merge 1 commit intokubeflow:masterfrom
puwun:chore/sdk-component-yaml-make-11698
Open

chore(test): use make commands in sdk-component-yaml. Fixes #11698#12755
puwun wants to merge 1 commit intokubeflow:masterfrom
puwun:chore/sdk-component-yaml-make-11698

Conversation

@puwun
Copy link

@puwun puwun commented Feb 1, 2026

Description of your changes:

  • Added test-component-yaml-install-deps and test-component-yaml-run make targets
  • Updated workflow to use make commands instead of inline shell commands

Checklist:

Fixes #11698

…11698

Signed-off-by: Pavan More <pavansmore05@gmail.com>
Copilot AI review requested due to automatic review settings February 1, 2026 15:42
@google-oss-prow google-oss-prow bot requested review from HumairAK and nsingla February 1, 2026 15:42
@google-oss-prow
Copy link

Hi @puwun. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the sdk-component-yaml workflow to use make commands instead of inline shell commands, aligning with the broader initiative to standardize workflow commands across the repository (issue #11494).

Changes:

  • Added two new make targets: test-component-yaml-install-deps for dependency installation and test-component-yaml-run for test execution
  • Updated the workflow to invoke these make targets instead of inline commands

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Makefile Added test-component-yaml-install-deps and test-component-yaml-run targets to encapsulate test setup and execution
.github/workflows/sdk-component-yaml.yml Replaced inline shell commands with make target invocations for cleaner and more maintainable workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 2, 2026

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zazulam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 2, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(<test>): https://github.com/kubeflow/pipelines/blob/master/.github/workflows/sdk-component-yaml.yml

3 participants