chore(test): use make commands in sdk-component-yaml. Fixes #11698#12755
chore(test): use make commands in sdk-component-yaml. Fixes #11698#12755puwun wants to merge 1 commit intokubeflow:masterfrom
sdk-component-yaml. Fixes #11698#12755Conversation
…11698 Signed-off-by: Pavan More <pavansmore05@gmail.com>
|
Hi @puwun. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This pull request refactors the sdk-component-yaml workflow to use make commands instead of inline shell commands, aligning with the broader initiative to standardize workflow commands across the repository (issue #11494).
Changes:
- Added two new make targets:
test-component-yaml-install-depsfor dependency installation andtest-component-yaml-runfor test execution - Updated the workflow to invoke these make targets instead of inline commands
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Added test-component-yaml-install-deps and test-component-yaml-run targets to encapsulate test setup and execution |
| .github/workflows/sdk-component-yaml.yml | Replaced inline shell commands with make target invocations for cleaner and more maintainable workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zazulam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Description of your changes:
test-component-yaml-install-depsandtest-component-yaml-runmake targetsChecklist:
Fixes #11698