Skip to content

Conversation

@Denyme24
Copy link

@Denyme24 Denyme24 commented Jan 17, 2026

Purpose of this PR

fixes #2793

Proposed changes:

Modified driverPodTemplateOption() and executorPodTemplateOption() in submission.go to always generate pod template files, even when they are not explicitly provided by users.

Changes

  • Removed the early return when app.Spec.Driver.Template == nil and app.Spec.Executor.Template == nil
  • Create minimal default pod templates with a base container structure when user templates are not provided
  • Ensure sparkConf pod template settings are properly applied via pod template files, even without explicit templates
  • Always write pod template files to:
    • /tmp/spark/{submissionID}/driver-pod-template.yaml
    • /tmp/spark/{submissionID}/executor-pod-template.yaml

Result

This ensures that sparkConf settings relying on pod templates (e.g., resource limits, node selectors, etc.) are respected regardless of whether users define pod templates in their SparkApplication spec.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Denyme24 <namanraj24@outlook.com>
@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey January 17, 2026 09:28
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vara-bonthu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Denyme24 <namanraj24@outlook.com>
@Denyme24
Copy link
Author

hey team @nabuskey @ImpSy, PTAL.

Signed-off-by: Denyme24 <namanraj24@outlook.com>
@Denyme24
Copy link
Author

hey @ChenYi015 @Shekharrajak, please review these changes.
thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pod Template defaults and SparkConfs being ignored

1 participant