fix: respect sparkConf pod template settings when spec.template is nil #2813
+20
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fixes #2793
Proposed changes:
Modified
driverPodTemplateOption()andexecutorPodTemplateOption()insubmission.goto always generate pod template files, even when they are not explicitly provided by users.Changes
app.Spec.Driver.Template == nilandapp.Spec.Executor.Template == nilsparkConfpod template settings are properly applied via pod template files, even without explicit templates/tmp/spark/{submissionID}/driver-pod-template.yaml/tmp/spark/{submissionID}/executor-pod-template.yamlResult
This ensures that
sparkConfsettings relying on pod templates (e.g., resource limits, node selectors, etc.) are respected regardless of whether users define pod templates in theirSparkApplicationspec.Change Category
Rationale
Checklist
Additional Notes