-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Expose metrics-labels flag via Spark Operator Helm chart #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose metrics-labels flag via Spark Operator Helm chart #2817
Conversation
Signed-off-by: Igor Stepanenko <[email protected]>
Signed-off-by: Igor Stepanenko <[email protected]>
|
/ok-to-test |
ChenYi015
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
@IgorSteps You need to sign off your commits to pass the DCO checks, see https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits. |
Signed-off-by: Igor Stepanenko <[email protected]>
7035ce6 to
5a5e7e0
Compare
ChenYi015
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Purpose of this PR
Expose the Spark Operator's
metrics-labelsflag as a Helm chart value so users can add custom labels (for example using standard K8s labels) to the Spark Operator standard metrics. Right now, the chart hard codes that flag toapp_typeso the documented ability to add your own label keys is not actually possible by developers using your Helm chart.This makes it much easier to build practical monitoring on whole platforms that use Spark Operator. Developers would be able to filter your standard metrics by e.g., namespace, app, component or team. They would have the ability to build common dashboards and setup targeted alerts without coming with elaborate ways to include enough information in the only available
app_typelabel to achieve that instead.Proposed changes:
prometheus.metrics.labelsvalue to the values.yaml;app_typefor backwards compatibility;Change Category
Rationale
This keeps the current
app_typevalue as default but lets users define their own custom labels.Checklist
Additional Notes
None.