Skip to content

Conversation

@IgorSteps
Copy link
Contributor

@IgorSteps IgorSteps commented Jan 24, 2026

Purpose of this PR

Expose the Spark Operator's metrics-labels flag as a Helm chart value so users can add custom labels (for example using standard K8s labels) to the Spark Operator standard metrics. Right now, the chart hard codes that flag to app_type so the documented ability to add your own label keys is not actually possible by developers using your Helm chart.

This makes it much easier to build practical monitoring on whole platforms that use Spark Operator. Developers would be able to filter your standard metrics by e.g., namespace, app, component or team. They would have the ability to build common dashboards and setup targeted alerts without coming with elaborate ways to include enough information in the only available app_type label to achieve that instead.

Proposed changes:

  • Adds prometheus.metrics.labels value to the values.yaml;
  • Uses it in the deployment if specified, otherwise defaults to app_type for backwards compatibility;
  • Helm chart automatic doc updates and unit test.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

This keeps the current app_type value as default but lets users define their own custom labels.

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

None.

@ChenYi015
Copy link
Member

/ok-to-test

@IgorSteps IgorSteps requested a review from ChenYi015 January 27, 2026 20:39
Copy link
Member

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ChenYi015
Copy link
Member

@IgorSteps You need to sign off your commits to pass the DCO checks, see https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits.

Signed-off-by: Igor Stepanenko <[email protected]>
@IgorSteps IgorSteps force-pushed the feat/helm-expose-metrics-labels-flag branch from 7035ce6 to 5a5e7e0 Compare January 28, 2026 19:04
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 28, 2026
@IgorSteps IgorSteps requested a review from ChenYi015 January 28, 2026 19:25
Copy link
Member

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 29, 2026
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c633117 into kubeflow:master Jan 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants